Add a setting to hide the prefix in the archive title #42594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +109 B (0%) Total Size: 1.28 MB
ℹ️ View Unchanged
|
carolinan
requested review from
ajitbohra,
ryanwelcher,
juanmaguitar and
fabiankaegy
as code owners
|
carolinan
changed the title
aristath
reviewed
Jul 25, 2022
aristath
reviewed
Jul 25, 2022
mikachan
reviewed
Jul 25, 2022
There was a problem hiding this comment.
Thanks for working on this! It's working well for me in testing.
Is there a better way than using the filter?
I just had a play around with this, and I didn't see anything better than the filter you've used. I think how you've done it is a good implementation.
Should date archives also have their prefix removed?
In my opinion, this prefix should also be removed, as I think it would be clear to users that date archive titles would behave the same as other archive titles.
How can we indicate what the setting does, while inside the editor? Maybe the default placeholder should be "Type: Archive title" and then "Archive title" when the option is toggled off.
It would be good to see the placeholder change when this option is toggled. I think "Type: Archive title" makes sense 👍 This keeps the wording consistent with the toggle label. Other alternatives could be: "Archive type: Archive title" or "Prefix: Archive title"
aristath
reviewed
Jul 25, 2022
|
How about these texts in the editor: I thought about Archive type: term or Archive type: taxonomy but they would technically be incorrect. I suppose that, one could look into detecting the actual archive type in the editor, based on the template, but that feels like it may lead down the rabbit hole and can be a separate PR... |
I like these, I think they represent the two different states well.
Yes, I see what you mean, I don't think it's immediately obvious what this means unless you're already aware of the term in this context.
I agree this could be a separate piece of work - I think this current PR is already valuable. |
24 tasks
mikachan
approved these changes
Aug 17, 2022
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Adds an option to hide the archive type in the title. "Category: Markup" would show as "Markup".
Closes #30519
Why?
How?
Testing Instructions
Screenshots or screencast