Add UI for toggling Summary fields #42546
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +196 B (0%) Total Size: 1.25 MB
ℹ️ View Unchanged
|
7 tasks
|
I understand why we've used the Design Tools UX here, but it feels a little off to me because the behaviours are not the same. For example, if I add margin to a group, then remove it via the tools panel, whatever margin value was set is then unset automatically. Whereas here, if I set a featured image, then toggle the Featured Image field off, it doesn't unset the featured image. This feels a little contradictory for something that uses the same design convention. This tangentially creates another inconsistency... the controls in design tools are universally linked to the block rather than the user. Using the same example as before, if I add margin to a block then all users will see that control. But in the summary panel, if I hide the Featured Image field, it's not entirely clear whether that is hidden just for me, or for all users. All that to say, this implementation can certainly work, and in isolation it feels pretty good! I'm just a bit concerned about the affect it might have on other areas of the UX. Side note: Not sure if its intentional but the 'Reset all' option didn't do what I expected – it removed everything. My expectation was that it would reset each field to its default visibility. |
|
Yeah that's a really good point. Maybe there should only be toggles for fields that can be "cleared" such as featured image and excerpt. That also means the ⋮ icon will start out as a + icon, which I think is more clear. Very possible that I've just misunderstood this since it looks like that's what @javierarce has in this mockup.
I haven't implemented that or any persistence yet 😀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Takes #42352 as a base and adds the ability to toggle the fields in Summary.
Why?
How?
Testing Instructions
Screenshots or screencast
Kapture.2022-07-20.at.16.34.53.mp4