Elements: fix heading and caption element selectors #42479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
added
[Type] Bug
|
Size Change: +70 B (0%) Total Size: 1.26 MB
ℹ️ View Unchanged
|
carolinan
approved these changes
Jul 20, 2022
|
Thanks for fixing this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR adds support for button / heading elements to the Site Editor.
Why?
The following PRs have added global style support for the heading and caption elements:
But it doesn't work in the Site Editor.
How?
There is also a list of supported elements in the Site Editor, so we need to add them to this list.
Testing Instructions
theme.jsondefined.theme.json
{ "version": 2, "settings": { "layout": { "contentSize": "650px" } }, "styles": { "elements": { "button": { "color": { "background": "blue" } }, "heading": { "color": { "background": "blue" } }, "caption": { "color": { "background": "blue" } } } } }core/headingblock and blocks with thecaptionelement into the site editor template.Sample HTML
Screenshots or screencast