Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update theme-json.md to include new element support and :ref #42412

Merged
merged 2 commits into from
Aug 1, 2022
Merged

Update theme-json.md to include new element support and :ref #42412

merged 2 commits into from
Aug 1, 2022

Conversation

carolinan
Copy link
Contributor

@carolinan carolinan commented Jul 14, 2022 •
edited
Loading

What?

  • Updates theme-json.md to include new element support, :ref and pseudo selectors.
  • Updates information about features available in 5.9 and 6.0, as there were sections that mentioned that Gutenberg was required.
  • Minor spacing fixes.

Why?

The new :ref was missing, and the list of supported elements did not include the latest updates.

How?

Testing Instructions

Screenshots or screencast

@carolinan carolinan added the [Type] Developer Documentation Documentation for developers label Jul 14, 2022
@carolinan carolinan requested a review from scruffian July 14, 2022 08:00
scruffian
scruffian approved these changes Jul 28, 2022
View reviewed changes
Copy link
Contributor

@scruffian scruffian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this.

@scruffian scruffian merged commit 79b78c6 into trunk Aug 1, 2022
@scruffian scruffian deleted the docs/theme-json-elements branch August 1, 2022 07:32
@github-actions github-actions bot added this to the Gutenberg 13.9 milestone Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scruffian scruffian scruffian approved these changes

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

@ryanwelcher ryanwelcher Awaiting requested review from ryanwelcher

@juanmaguitar juanmaguitar Awaiting requested review from juanmaguitar juanmaguitar is a code owner

@fabiankaegy fabiankaegy Awaiting requested review from fabiankaegy fabiankaegy is a code owner

Assignees
No one assigned
Labels
[Type] Developer Documentation Documentation for developers
Projects
None yet
Milestone
Gutenberg 13.9
Development

Successfully merging this pull request may close these issues.
2 participants
@carolinan @scruffian