Prevent link control popover from going offscreen #42389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talldan
added
[Type] Bug
talldan
requested review from
ellatrix,
fluiddot,
tellthemachines and
ajitbohra
as code owners
|
Size Change: +23 B (0%) Total Size: 1.25 MB
ℹ️ View Unchanged
|
|
Thanks for the PR Dan! In site editor we see this: Screen.Recording.2022-07-13.at.2.38.11.PM.movThis seems related to the issue in my comment here: #41575 (comment). |
|
This could have been added to 6.0.1. It's funny how the WP team keeps adding GUI features without properly testing them on all screen sizes before launch, and then these PR are constantly needed to fix them. |
@andreszs This PR is related to a Gutenberg plugin bug. It may be that a similar issue happens in 6.0.1, but the problem in the code will be unrelated because the popover code has been completely replaced in the Gutenberg plugin! I completely agree there could be better testing before merging new features. ❤️
@ntsekouras It's a much needed improvement over what's in edit: So it seems that It's quite difficult to reason about what |
|
@ntsekouras I think I understand the issue. Floating UI expects consumers to use its own Without that data the |
|
Good find @talldan!! We might need a wrapper offset middleware that always adds offset, even if we pass |
|
#42417 switches from custom middleware to floating-ui's middleware for frame offset. I found this issue that suggests floating ui may work automatically with iframes in the future - floating-ui/floating-ui#1711. 🤞 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes #42003
Doesn't really help with #41739
Prevents the LinkControl popover from going offscreen.
Why?
It's a bug - it's hard to use the popover when it's half off the screen. 😏
How?
Adds the
__unstableShiftprop to the popovers. This prop allows the popover to shift position in all axes relative to the reference/anchor element when the popover would otherwise be positioned offscreen or behind another element.Note - I added this to the navigation link/submenu popovers, but due their z-index they don't seem to behave exactly like the other popovers.
Testing Instructions
I've tested this in the customize widgets screen and there's now a separate issue:
It looks like something happened to the z-index or stacking context. Either that or the popover previously resized.
Screenshots or screencast
Before
Kapture.2022-07-13.at.17.03.11.mp4
After
Kapture.2022-07-13.at.17.01.51.mp4