Disable drop cap control if text is aligned #42326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carolinan
changed the title
|
Size Change: +378 B (0%) Total Size: 1.26 MB
ℹ️ View Unchanged
|
carolinan
commented
Jul 14, 2022
carolinan
added
[Block] Paragraph
carolinan
changed the title
aristath
reviewed
Jul 14, 2022
carolinan
commented
Jul 27, 2022
|
Thanks for working on this! I'm getting an error trying to compile this branch: Here's the trunk behavior: Question: if I apply the dropcap when left-aligned, and then center or right aligned, is the drop cap removed? In principle it makes total sense to remove the drop cap for center and right aligned, as it won't look very good there. Thanks for the PR! |
|
I think something may have gone wrong with the trunk merge, I will check if I can build it. |
|
I found that Yes on LTR the drop cap is removed if the text is centered or right aligned and can be added again when left aligned or if no alignment is selected. Screen.Recording.2022-09-20.at.11.16.58.mov |
|
Looks good. Instead of "Aligned text can not have a drop cap", can we change that to "Not available for aligned text"? |
aristath
approved these changes
Sep 20, 2022
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Disables drop cap control for paragraph blocks if the text is aligned to:
Fixes #11756
Why?
The drop cap did not work if the text was aligned because the first letter was not aligned with the rest of the text.
The drop cap also did not work on RTL where the first letter was in the wrong position.
How?
When the text is aligned:
dropCapis updated as well as the .has-drop-cap CSS classname.Testing Instructions
Please test the deprecation:
One each for no alignment, left, center and right alignment.
Testing the functionality:
Repeat step 3.
Confirm that the drop cap option is available for the left aligned block and the block with no alignment.
Confirm that it is disabled for the centered and right alignment.
Switch to an RTL language.
Refresh the post or page and confirm that there are no block validation errors.
Please confirm that when you switch to RTL, the left aligned block still displays the drop cap, but the drop cap control is disabled for this alignment.
Open the Advanced panel in the block settings sidebar.
Confirm that the has-drop-cap class is in the CSS field. Remove it.
Confirm that you were able to remove the visual drop cap.
Check the front:
Confirm that the drop cap is placed on the right side of the RTL text and that the spacing (margin) is correct.
Screenshots or screencast