-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Data: Experiment with loading logger middleware #42183
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyxla
added
[Type] Performance
Related to performance efforts
[Status] Blocked
Used to indicate that a current effort isn't able to move forward
[Package] Data
/packages/data
[Type] Experimental
Experimental feature or API.
labels
Jul 6, 2022
tyxla
force-pushed
the
try/observe-loading-progress
branch
from
July 6, 2022 12:32
e7260d6
to
93933d7
Compare
Size Change: +198 B (0%) Total Size: 1.25 MB
ℹ️ View Unchanged
|
Closing as this experiment has done its purpose and has been superseded by #42525. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Package] Data
/packages/data
[Status] Blocked
Used to indicate that a current effort isn't able to move forward
[Type] Experimental
Experimental feature or API.
[Type] Performance
Related to performance efforts
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR is an experiment - DO NOT MERGE.
It intends to add a simple logger middleware to the resolutions of the data package.
Why?
This can be helpful in observing what data we're loading, how long it takes, and more specifically the order in which it happens.
This can be useful in order to investigate the next steps in improving the editor loading experience.
See #35503
How?
A simple middleware that logs to the browser console.
Testing Instructions
Open the editor with your browser console open, and observe the messages.
Screenshots or screencast