Elements: lower specificity of elements block css #41931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaggieCabrera
requested review from
getdave,
jffng,
mikachan,
scruffian and
draganescu
MaggieCabrera
added
the
Global Styles
|
Size Change: +30 B (0%) Total Size: 1.25 MB
ℹ️ View Unchanged
|
scruffian
approved these changes
Jun 24, 2022
|
How would you feel about removing this hardcoded font size? |
draganescu
added
[Type] Bug
|
@carolinan may it be a good separate issue with a Needs Design Feedback label? |
|
I'd love to remove it. My main concern is that it will change the appearance of user's sites without them knowing. The nice thing about this approach is that if users add new file blocks they will use the standard size, so I don't think there is a need to override it in Global Styles for the file block. |
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR fixes an issue with the default font size defined for the file block not being overridden by theme.json button element rules.
Why?
After #41822 got merged, the block.json defaults where generating a CSS that was more specific than the one generated by a themes theme.json file for the same element, so it was always being applied.
How?
I removed the default font size definition and moved it to the CSS, and made it only apply to non element file buttons.
Testing Instructions
On a block theme add this to theme.json:
Insert a file block and check the font size of the button. Without this PR it's always 0.8em, with this PR it should apply what's on theme.json.
If the block doesn't have the
.wp-element-buttonclass, the 0.8em should be applying, keeping backward compat.Screenshots or screencast
Before:
After: