Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Border Controls: Update control components to allow 40px height #41860

Merged
merged 31 commits into from
Oct 26, 2022
Merged

Border Controls: Update control components to allow 40px height #41860

merged 31 commits into from
Oct 26, 2022

Commits on Oct 26, 2022

  1. Update border control components to allow 40px height

    @aaronrobertshaw
    aaronrobertshaw committed Oct 26, 2022
    Configuration menu
    Copy the full SHA
    90593ce View commit details
    Browse the repository at this point in the history

  2. Make 40px height work again after rebase

    @aaronrobertshaw
    aaronrobertshaw committed Oct 26, 2022
    Configuration menu
    Copy the full SHA
    9790ab1 View commit details
    Browse the repository at this point in the history

  3. Turn on 40px tall border controls in editors

    @aaronrobertshaw
    aaronrobertshaw committed Oct 26, 2022
    Configuration menu
    Copy the full SHA
    b75fab1 View commit details
    Browse the repository at this point in the history

  4. Update radius control to handle extra padding 

    These tweaks update the BorderRadiusControl such that the entered values are actually visible despite the increased internal padding applied to the UnitControl when the `__unstable-large` variant is used.
    @aaronrobertshaw
    aaronrobertshaw committed Oct 26, 2022
    Configuration menu
    Copy the full SHA
    d326242 View commit details
    Browse the repository at this point in the history

  5. First pass at improving border controls when at 40px 

    Initial tweaks to improve the UX for the border controls. Aims to address the increased padding for large 40px high UnitControl variant that cuts of entered values from display.
    @aaronrobertshaw
    aaronrobertshaw committed Oct 26, 2022
    Configuration menu
    Copy the full SHA
    d7bf4f2 View commit details
    Browse the repository at this point in the history

  6. Make compact inputs 118px wide

    @aaronrobertshaw
    aaronrobertshaw committed Oct 26, 2022
    Configuration menu
    Copy the full SHA
    2d53942 View commit details
    Browse the repository at this point in the history

  7. Increase padding to 16px between input and slider

    @aaronrobertshaw
    aaronrobertshaw committed Oct 26, 2022
    Configuration menu
    Copy the full SHA
    9d80fc5 View commit details
    Browse the repository at this point in the history

  8. Make split controls gap a uniform 16px

    @aaronrobertshaw
    aaronrobertshaw committed Oct 26, 2022
    Configuration menu
    Copy the full SHA
    72b76c8 View commit details
    Browse the repository at this point in the history

  9. Update split layout for floating linked button

    @aaronrobertshaw
    aaronrobertshaw committed Oct 26, 2022
    Configuration menu
    Copy the full SHA
    830aa01 View commit details
    Browse the repository at this point in the history

  10. Make color dropdown 40px square with 16px indicator

    @aaronrobertshaw
    aaronrobertshaw committed Oct 26, 2022
    Configuration menu
    Copy the full SHA
    48e64a7 View commit details
    Browse the repository at this point in the history

  11. Tweak input widths again to fit editor sidebar

    @aaronrobertshaw
    aaronrobertshaw committed Oct 26, 2022
    Configuration menu
    Copy the full SHA
    2915b46 View commit details
    Browse the repository at this point in the history

  12. Make radius control match border and grid

    @aaronrobertshaw
    aaronrobertshaw committed Oct 26, 2022
    Configuration menu
    Copy the full SHA
    58c9dfa View commit details
    Browse the repository at this point in the history

  13. Remove hardcoded width from radius input wrapper

    @aaronrobertshaw
    aaronrobertshaw committed Oct 26, 2022
    Configuration menu
    Copy the full SHA
    5f8116c View commit details
    Browse the repository at this point in the history

  14. Try using Mix as placeholder for mixed values

    @aaronrobertshaw
    aaronrobertshaw committed Oct 26, 2022
    Configuration menu
    Copy the full SHA
    b19f53a View commit details
    Browse the repository at this point in the history

  15. Revert placeholder back to 'Mixed'

    @aaronrobertshaw
    aaronrobertshaw committed Oct 26, 2022
    Configuration menu
    Copy the full SHA
    accd0ee View commit details
    Browse the repository at this point in the history

  16. Remove use of internal component classnames

    @aaronrobertshaw
    aaronrobertshaw committed Oct 26, 2022
    Configuration menu
    Copy the full SHA
    b7f5f16 View commit details
    Browse the repository at this point in the history

  17. Remove unnecessary flex styles from linked button

    @aaronrobertshaw
    aaronrobertshaw committed Oct 26, 2022
    Configuration menu
    Copy the full SHA
    2e9b3db View commit details
    Browse the repository at this point in the history

  18. Use space util for color swatch dimensions

    @aaronrobertshaw
    aaronrobertshaw committed Oct 26, 2022
    Configuration menu
    Copy the full SHA
    4aef1a9 View commit details
    Browse the repository at this point in the history

  19. Add explanatory comment for compact widths

    @aaronrobertshaw
    aaronrobertshaw committed Oct 26, 2022
    Configuration menu
    Copy the full SHA
    dceccae View commit details
    Browse the repository at this point in the history

  20. Better align the left border for 30px height variant

    @aaronrobertshaw
    aaronrobertshaw committed Oct 26, 2022
    Configuration menu
    Copy the full SHA
    2b7d6bd View commit details
    Browse the repository at this point in the history

  21. Consolidate border radius controls to single 40px height 

    This allows us to remove most of the changes that would have been introduced in this PR as well as simplify the CSS.
    @aaronrobertshaw
    aaronrobertshaw committed Oct 26, 2022
    Configuration menu
    Copy the full SHA
    3356b5c View commit details
    Browse the repository at this point in the history

  22. Fix RTL rendering and style naming

    @aaronrobertshaw
    aaronrobertshaw committed Oct 26, 2022
    Configuration menu
    Copy the full SHA
    033c1c3 View commit details
    Browse the repository at this point in the history

  23. Remove unneeded prop setting 40px height

    @aaronrobertshaw
    aaronrobertshaw committed Oct 26, 2022
    Configuration menu
    Copy the full SHA
    3c4d6fb View commit details
    Browse the repository at this point in the history

  24. Switch __next40pxDefaultSize to size __unstable-large

    @aaronrobertshaw
    aaronrobertshaw committed Oct 26, 2022
    Configuration menu
    Copy the full SHA
    6fa39c3 View commit details
    Browse the repository at this point in the history

  25. Fix up defaults in types and update READMEs

    @aaronrobertshaw
    aaronrobertshaw committed Oct 26, 2022
    Configuration menu
    Copy the full SHA
    ffe04fa View commit details
    Browse the repository at this point in the history

  26. Add components changelog

    @aaronrobertshaw
    aaronrobertshaw committed Oct 26, 2022
    Configuration menu
    Copy the full SHA
    f8c241b View commit details
    Browse the repository at this point in the history

  27. Rename new prop __unstableWrapperClassName

    @aaronrobertshaw
    aaronrobertshaw committed Oct 26, 2022
    Configuration menu
    Copy the full SHA
    67c372e View commit details
    Browse the repository at this point in the history

  28. UnitControl: Normalize wrapper classnames by removing outer wrapper (#… 

    …45139)
    @aaronrobertshaw
    aaronrobertshaw committed Oct 26, 2022
    Configuration menu
    Copy the full SHA
    91b2a2e View commit details
    Browse the repository at this point in the history

  29. BorderBoxControl: Refactor stories to TypeScript and Controls (#45002)

    @aaronrobertshaw
    aaronrobertshaw committed Oct 26, 2022
    Configuration menu
    Copy the full SHA
    1cff757 View commit details
    Browse the repository at this point in the history

  30. Remove max-width wrappers from border control stories

    @aaronrobertshaw
    aaronrobertshaw committed Oct 26, 2022
    Configuration menu
    Copy the full SHA
    832c018 View commit details
    Browse the repository at this point in the history

  31. Merge branch 'trunk' into update/border-controls-to-40px-height

    @ciampo
    ciampo authored Oct 26, 2022
    Configuration menu
    Copy the full SHA
    e8caff1 View commit details
    Browse the repository at this point in the history