-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set Default state to media library for library button in image block #41678
Set Default state to media library for library button in image block #41678
Conversation
This tested well for me. Should we document the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on Image, Gallery and Cover block and worked correctly on all. Thanks for this fix 🎉
Thank you. glendaviesnz. |
@Mamaduka Can you please review the PR. Thank you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sunil25393, it looks like this was already reviewed by @glendaviesnz. So I'm going to merge the PR.
Added the Needs Dev Note label in case this needs a dev note (either individual or as part of a "misc" dev note) for WP 6.1 release. |
In Gutenberg Image Block, on click of 'Media Library' button it should open Media Library tab in Media Popup. Instead, it open last opened tab. It confusing for user when they specifically click Media Library button and end up on upload tab in media Popup.
What?
Fixes #41473
Testing Instructions
Please follow step by step instructions to test this PR.
Media Library
button.Upload
TabMedia Library
button.Media Library
tab in Dialog.Screenshots or screencast