Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RangeControl: Convert unit tests to typescript #41445

Merged
merged 31 commits into from
Jul 12, 2022
Merged

RangeControl: Convert unit tests to typescript #41445

merged 31 commits into from
Jul 12, 2022

Commits on Jul 12, 2022

  1. Convert RangeControl to TypeScript

    @aaronrobertshaw
    aaronrobertshaw committed Jul 12, 2022
    Configuration menu
    Copy the full SHA
    da9f81f View commit details
    Browse the repository at this point in the history

  2. Add named export for docgen

    @aaronrobertshaw
    aaronrobertshaw committed Jul 12, 2022
    Configuration menu
    Copy the full SHA
    71b528f View commit details
    Browse the repository at this point in the history

  3. Add changelog

    @aaronrobertshaw
    aaronrobertshaw committed Jul 12, 2022
    Configuration menu
    Copy the full SHA
    b22fc98 View commit details
    Browse the repository at this point in the history

  4. Fix naming of component

    @aaronrobertshaw
    aaronrobertshaw committed Jul 12, 2022
    Configuration menu
    Copy the full SHA
    24320dc View commit details
    Browse the repository at this point in the history

  5. Rename and make icon props optional

    @aaronrobertshaw
    aaronrobertshaw committed Jul 12, 2022
    Configuration menu
    Copy the full SHA
    8bb4c17 View commit details
    Browse the repository at this point in the history

  6. Add additional descriptions for icon types

    @aaronrobertshaw
    aaronrobertshaw committed Jul 12, 2022
    Configuration menu
    Copy the full SHA
    60cca10 View commit details
    Browse the repository at this point in the history

  7. Improve color type descriptions

    @aaronrobertshaw
    aaronrobertshaw committed Jul 12, 2022
    Configuration menu
    Copy the full SHA
    c3adac8 View commit details
    Browse the repository at this point in the history

  8. Omit as prop from WordPressComponentProps

    @aaronrobertshaw
    aaronrobertshaw committed Jul 12, 2022
    Configuration menu
    Copy the full SHA
    57f23cc View commit details
    Browse the repository at this point in the history

  9. Remove unnecessary backticks from type default

    @aaronrobertshaw
    aaronrobertshaw committed Jul 12, 2022
    Configuration menu
    Copy the full SHA
    d76dd77 View commit details
    Browse the repository at this point in the history

  10. Expand type definitions in RangeControlProps for better storybook docs

    @aaronrobertshaw
    aaronrobertshaw committed Jul 12, 2022
    Configuration menu
    Copy the full SHA
    057b4a8 View commit details
    Browse the repository at this point in the history

  11. Fix tooltip regression when step is any

    @aaronrobertshaw
    aaronrobertshaw committed Jul 12, 2022
    Configuration menu
    Copy the full SHA
    54719d3 View commit details
    Browse the repository at this point in the history

  12. Fix removal of polymorphism for RangeControl

    @aaronrobertshaw
    aaronrobertshaw committed Jul 12, 2022
    Configuration menu
    Copy the full SHA
    9b18165 View commit details
    Browse the repository at this point in the history

  13. Fix post-rebase typing errors

    @aaronrobertshaw
    aaronrobertshaw committed Jul 12, 2022
    Configuration menu
    Copy the full SHA
    af0b3ad View commit details
    Browse the repository at this point in the history

  14. Minimise runtime changes via ts-expect-error 

    See: #40535 (comment) for more information on why we are ignoring this error. TL;DR we are looking to address some conflicts between input control types for their value props.
    @aaronrobertshaw
    aaronrobertshaw committed Jul 12, 2022
    Configuration menu
    Copy the full SHA
    d2ae390 View commit details
    Browse the repository at this point in the history

  15. Clarify icon prop descriptions

    @aaronrobertshaw
    aaronrobertshaw committed Jul 12, 2022
    Configuration menu
    Copy the full SHA
    8c2c5e2 View commit details
    Browse the repository at this point in the history

  16. Revert resetFallbackValue type to number

    @aaronrobertshaw
    aaronrobertshaw committed Jul 12, 2022
    Configuration menu
    Copy the full SHA
    da940c5 View commit details
    Browse the repository at this point in the history

  17. Remove unrequired className from WrapperProps

    @aaronrobertshaw
    aaronrobertshaw committed Jul 12, 2022
    Configuration menu
    Copy the full SHA
    775fafe View commit details
    Browse the repository at this point in the history

  18. Fix WordPressComponentProps and ForwardedRef types

    @aaronrobertshaw
    aaronrobertshaw committed Jul 12, 2022
    Configuration menu
    Copy the full SHA
    b0914c9 View commit details
    Browse the repository at this point in the history

  19. Leverage useMergeRefs to fix for modern refs

    @aaronrobertshaw
    aaronrobertshaw committed Jul 12, 2022
    Configuration menu
    Copy the full SHA
    0b7ea66 View commit details
    Browse the repository at this point in the history

  20. Fix rebase error

    @aaronrobertshaw
    aaronrobertshaw committed Jul 12, 2022
    Configuration menu
    Copy the full SHA
    357eedf View commit details
    Browse the repository at this point in the history

  21. Remove unused SetControlledRangeValue type

    @aaronrobertshaw
    aaronrobertshaw committed Jul 12, 2022
    Configuration menu
    Copy the full SHA
    3f5e9d0 View commit details
    Browse the repository at this point in the history

  22. Fix onShowTooltip and onHideTooltip types

    @aaronrobertshaw
    aaronrobertshaw committed Jul 12, 2022
    Configuration menu
    Copy the full SHA
    70f331e View commit details
    Browse the repository at this point in the history

  23. Remove types from JSDocs

    @aaronrobertshaw
    aaronrobertshaw committed Jul 12, 2022
    Configuration menu
    Copy the full SHA
    822d757 View commit details
    Browse the repository at this point in the history

  24. Improve useControlledRangeValue hook types

    @aaronrobertshaw
    aaronrobertshaw committed Jul 12, 2022
    Configuration menu
    Copy the full SHA
    2887c5b View commit details
    Browse the repository at this point in the history

  25. Fix copy and pasted typo

    @aaronrobertshaw
    aaronrobertshaw committed Jul 12, 2022
    Configuration menu
    Copy the full SHA
    d5086e2 View commit details
    Browse the repository at this point in the history

  26. Apply suggested feedback to remove runtime changes

    @aaronrobertshaw
    aaronrobertshaw committed Jul 12, 2022
    Configuration menu
    Copy the full SHA
    cace914 View commit details
    Browse the repository at this point in the history

  27. Tweak JSDoc comments and typing

    @aaronrobertshaw
    aaronrobertshaw committed Jul 12, 2022
    Configuration menu
    Copy the full SHA
    c2c7d1e View commit details
    Browse the repository at this point in the history

  28. Fix case for custom hook types

    @aaronrobertshaw
    aaronrobertshaw committed Jul 12, 2022
    Configuration menu
    Copy the full SHA
    f19616e View commit details
    Browse the repository at this point in the history

  29. Convert unit tests to TypeScript

    @aaronrobertshaw
    aaronrobertshaw committed Jul 12, 2022
    Configuration menu
    Copy the full SHA
    929d907 View commit details
    Browse the repository at this point in the history

  30. Remove use of querySelector from tests

    @aaronrobertshaw
    aaronrobertshaw committed Jul 12, 2022
    Configuration menu
    Copy the full SHA
    0cecf0e View commit details
    Browse the repository at this point in the history

  31. Remove role=img from Icons and revert to using querySelector 

    See: #41445 (comment)
    @aaronrobertshaw
    aaronrobertshaw committed Jul 12, 2022
    Configuration menu
    Copy the full SHA
    1b53957 View commit details
    Browse the repository at this point in the history