Fix customizer block toolbar after popover refactor #41312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
the
[Type] Bug
|
Size Change: +24 B (0%) Total Size: 1.24 MB
ℹ️ View Unchanged
|
Mamaduka
requested changes
May 25, 2022
There was a problem hiding this comment.
Thanks for the quick follow-up, Riad.
I noticed that the Block Settings dropdown is also "cut" adding following code fixes issue for me:
.customize-widgets-popover .block-editor-block-settings-menu__popover {
position: fixed !important;
}Screenshot
Before
After
packages/customize-widgets/src/components/sidebar-block-editor/style.scss
Show resolved
Hide resolved
|
@Mamaduka I've used a bit more generic selector to target all toolbar popovers and not just the "more menu" one. |
Mamaduka
approved these changes
May 25, 2022
|
@youknowriad, the failing Playwright tests might be related to the changes in this PR. |
|
The 8a990c8 should fix failing tests. The Block Toolbar was overlapping with the inserter, making it impossible to click on the searched block.
|
|
All checks are passing, so I'm going to merge this. @youknowriad, @kevin940726, I'm happy to do a follow-up if you've got a better alternative for 8a990c8. |
|
Thanks for the help @Mamaduka |
youknowriad
added a commit
that referenced
this pull request
May 26, 2022
* Fix customizer block toolbar after popover refactor * Fix more popovers * Fix e2e test Co-authored-by: George Mamadashvili <georgemamadashvili@gmail.com>
priethor
added
the
[Feature] Widgets Customizer
67 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #35496
What?
The block toolbar popover was being "cut" in the customizer sidebar (widgets). This PR fixes it.
How?
As recommended by floatingui, the Popover component now renders the "position" as inline style (after the refactor in #40740 ) which was overriding the "fixed" position override we had for block popover in the customizer. This PR just forces the fixed position in that case.
This should probably fixed the flaky e2e test we have right now.
Testing Instructions
1- Pick the 2019 theme
2- Go to the widgets sidebar in the customizer
3- Select blocks
4- the block toolbar should be shown entirely (not cut)