Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use @testing-library/user-event in TimePicker tests #41270

Merged
merged 3 commits into from
May 25, 2022
Merged

Use @testing-library/user-event in TimePicker tests #41270

merged 3 commits into from
May 25, 2022

Conversation

noisysocks
Copy link
Member

What?

Updates the TimePicker unit tests to use @testing-library/user-event for interacting with the component.

Why?

How?

https://testing-library.com/docs/ecosystem-user-event/

Testing Instructions

npm run test-unit

@noisysocks noisysocks added [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. [Package] Components /packages/components labels May 24, 2022
@noisysocks noisysocks mentioned this pull request May 24, 2022
Merged
ciampo
ciampo approved these changes May 24, 2022
View reviewed changes
Copy link
Contributor

@ciampo ciampo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's great to see more components adopting @testing-library/user-event !

Thank you for your work 🚀

@ciampo ciampo added the [Type] Enhancement A suggestion for improvement. label May 24, 2022
@noisysocks noisysocks merged commit 9e7bad0 into trunk May 25, 2022
@noisysocks noisysocks deleted the update/use-user-event-in-TimePicker-tests branch May 25, 2022 00:17
@github-actions github-actions bot added this to the Gutenberg 13.4 milestone May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ciampo ciampo ciampo approved these changes

@kevin940726 kevin940726 Awaiting requested review from kevin940726

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

Assignees
No one assigned
Labels
[Package] Components /packages/components [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
Gutenberg 13.4
Development

Successfully merging this pull request may close these issues.
2 participants
@noisysocks @ciampo