Gallery block: Include image caption when converting a classic block gallery #40872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glendaviesnz
added
the
[Block] Gallery
|
Size Change: +27 B (0%) Total Size: 1.23 MB
ℹ️ View Unchanged
|
carolinan
approved these changes
May 6, 2022
19 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Includes image caption if set when transforming a Classic block Gallery/Short code
Fixes: #19921
Why?
Currently the image captions are lost when converting a Classic block gallery to a Gallery block
How?
Transfers the caption retrieved from getMedia call to the new Image block attribs
Testing Instructions
Convert to blocksbutton in the toolbarScreenshots or screencast
Before:
captions-before2.mp4
After:
captions-after.mp4