UnitControl: avoid calling onChange callback twice when unit changes #40796
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Prior to this PR, the
onChange
callback onUnitControl
is called twice when the unit changes.Why?
Just an error in the component's logic.
This bug was uncovered by the work done in #40790 (comment) while a solution was, at the same time, already being proposed by @stokesman as part of #40568.
This PR extracts the fix from #40568, while also updating the corresponding unit test.
How?
Removed the call to
onChange
from within themayUpdateUnit
function.Testing Instructions
onChange
andonUnitChange
callbacks toUnitControl
. Interact with the component by changing the unit from the dropdown. Make sure that the both callbacks are called, but thatonChange
is called only once.