Fix style comment awaiting moderation indentation #40681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +161 B (0%) Total Size: 1.23 MB
ℹ️ View Unchanged
|
cbravobernal
added
[Type] Bug
|
Nice one. I can confirm the issue in trunk: I wonder if there's a differnt way to solve this, though. Right now the issue appears because there's a 3.25em left padding on the main comment, which is then paired with a negative 3.25em margin later down the stack: If we remove that initial padding, and the negative margin, the issue appears solved for me simply by virtue of the avatar floating left: I have a sense that the left padding exists to indent the comment metadata in case it wraps onto multiple lines. In such a case, the subsequent lines would wrap below the avatar, rather than vertically down. However if this is the intent, I don't think we should do it: a hard-coded padding/margin like that won't work if we resize the avatar. Whereas if the avatar is floated and indents naturally, it will work even when resizing. What do you think? One final thought, should we add something like this? That would give some clearance around the message: |
I thought about it, but maybe changing that will affect all current Block themes that are using Comments. I guess theme developers handled this issue before, so we may force them to update all themes if we now remove that padding. Adding the positive margin feels like a patch to be honest, but at least we are not affecting a really common div.
That way looks much better. |
This would only be the case if a block theme used the comments query loop block, and added custom CSS to override parts of this, correct? If yes, then I wouldn't worry too much about changing that, I think it's important we move towards the best code structure when we can. Or is this code ported from the classic comments loop? |
Not sure I'm understanding the question entirely correctly, but this styling is for the ("monolithic") Post Comments block, which is basically a thin wrapper around WP's (It's unrelated to the new "modularized" Comments Query Loop block, although we did find this issue when working on that block.) |
|
Ah, thank you for the clarification. Still, thinking in terms of the styles output by packages/block-library/src/post-comments/style.scss on the frontend, the margin/padding changes could be argued as being in the bugfix category, and would work fine even for TwentyTwentyTwo on updating the plugin or major WordPress version, assuming TT2 or any other theme using it relies on that particular margin and padding for some other custom styles. In other words, it seems like the potential breakage of refactoring the code would be minimal, and therefore probably good to fix the issue. Not a strong opinion, but just a general opportunity to improve the code, perhaps! |
Then, should we remove the margin and leave everything aligned? That way the theme is responsible for styling the layout. |
|
Nice! Thank you. I'm unable to test at this point, but the code seems good, and looks like what I tried in the inspector. 👍 👍 on my part |
ockham
added
the
Backport to WP 6.7 Beta/RC
|
@adamziel This one would also be great to get into Beta 4, if possible 😊 |
|
I cherry picked this change into |
adamziel
removed
the
Backport to WP 6.7 Beta/RC
gziolo
pushed a commit
that referenced
this pull request
May 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixed indentation on
Post Comments Blockof the moderation warning message.Testing Instructions
Screenshots or screencast
Before:
After:
