Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reorder blocks via drag & drop (v1. using React-dnd). #4056

Closed
wants to merge 12 commits into from
Closed

Reorder blocks via drag & drop (v1. using React-dnd). #4056

wants to merge 12 commits into from

Commits on Dec 17, 2017

  1. Drag & Drop for blocks: Added react-dnd dependencies.

    @chriskmnds
    chriskmnds committed Dec 17, 2017
    Configuration menu
    Copy the full SHA
    cca62d7 View commit details
    Browse the repository at this point in the history

  2. Drag & Drop: Added functionality for reindexing blocks. 

    - Updated editor reducers and actions to allow reindexing of blocks given uid of block to be reindexed and the new index position.
    @chriskmnds
    chriskmnds committed Dec 17, 2017
    Configuration menu
    Copy the full SHA
    264d3cb View commit details
    Browse the repository at this point in the history

  3. Drag & Drop for blocks: Added wrappers to the react-dnd higher order … 

    …components.

- Centralised the dependency on react-dnd to provide custom entry points for the available/required HOCs.
    @chriskmnds
    chriskmnds committed Dec 17, 2017
    Configuration menu
    Copy the full SHA
    b00ec8c View commit details
    Browse the repository at this point in the history

  4. Drag & Drop for blocks: Updated constants to add draggable types. 

    - Updated editor constants to include draggable types, as required to connect drag sources to drop targets in react-dnd.
    @chriskmnds
    chriskmnds committed Dec 17, 2017
    Configuration menu
    Copy the full SHA
    2bfc54f View commit details
    Browse the repository at this point in the history

  5. Drag & Drop for blocks: Added a draggable component set for specifyin… 

    …g drag sources and drop targets.

- Can define and use these components anywhere on the page.
- Can be customised via component properties.
    @chriskmnds
    chriskmnds committed Dec 17, 2017
    Configuration menu
    Copy the full SHA
    20f0c9d View commit details
    Browse the repository at this point in the history

  6. Drag & Drop for blocks: Added state flag for keeping track of drag op… 

    …erations.

- May not be needed eventually, depending on how we decide to deal with the conflicts between the current dropzone provider and react-dnd.
    @chriskmnds
    chriskmnds committed Dec 17, 2017
    Configuration menu
    Copy the full SHA
    e629af0 View commit details
    Browse the repository at this point in the history

  7. Drag & Drop for blocks: Added drag source and drop target components … 

    …to the block list for testing.
    @chriskmnds
    chriskmnds committed Dec 17, 2017
    Configuration menu
    Copy the full SHA
    93bdd74 View commit details
    Browse the repository at this point in the history

Commits on Dec 18, 2017

  1. Drag & Drop for blocks: Added react-dnd-html5-mixed-backend dependenc… 

    …y and removed experimental react-dnd provider.

- Added dependency to a fork of the HTML5 backend used for react-dnd. This fixes the conflicts with having both react-dnd and custom event listeners on the page.
    @chriskmnds
    chriskmnds committed Dec 18, 2017
    Configuration menu
    Copy the full SHA
    6ea53a4 View commit details
    Browse the repository at this point in the history

  2. Drag & Drop for blocks: Some cleanup, reenabled drop zone with flag.

    @chriskmnds
    chriskmnds committed Dec 18, 2017
    Configuration menu
    Copy the full SHA
    9cd6578 View commit details
    Browse the repository at this point in the history

  3. Drag & Drop for blocks: Fixed block reordering issue with reduntant c… 

    …all to 'without', as per Andrew's comment in the PR.
    @chriskmnds
    chriskmnds committed Dec 18, 2017
    Configuration menu
    Copy the full SHA
    866238a View commit details
    Browse the repository at this point in the history

Commits on Dec 20, 2017

  1. Drag & Drop for blocks: Updated block reindex reducer and added respe… 

    …ctive tests.
    @chriskmnds
    chriskmnds committed Dec 20, 2017
    Configuration menu
    Copy the full SHA
    de1b3fd View commit details
    Browse the repository at this point in the history

  2. Drag & Drop for blocks: Fixed indendation errors.

    @chriskmnds
    chriskmnds committed Dec 20, 2017
    Configuration menu
    Copy the full SHA
    6ee16a4 View commit details
    Browse the repository at this point in the history