-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
InputControl: Fix undo when changing padding values #40518
Merged
Merged
Commits on May 29, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 070a66e - Browse repository at this point
Copy the full SHA 070a66eView commit details -
Finish making
InputControl
et al. more controllable (#40568)* Update `RangeControl` to play nice with revised `InputControl` * Update `UnitControl` to play nice with revised `InputControl` * Restore controlled mode to `RangeControl` * Add missing ; * Add comment after deleting `onChange` * Update test of `RangeControl` to also test controlled mode * Remove separate onChange call from reset handling in `RangeControl` * Refine RESET logic of `InputControl` reducer * Simplify refined RESET logic of `InputControl` reducer * Restore initial position of `RangeControl` when without value * Differentiate state sync effect hooks by event existence * Add and use type `SecondaryReducer` * Cleanup legacy `event.perist()` * Simplify update from props in reducer Co-authored-by: Lena Morita <lena@jaguchi.com> * Ensure event is cleared after drag actions * Avoid declaration of potential unused variable * Add more reset unit tests for `RangeControl` * Run `RangeControl` unit test in both controlled/uncontrolled modes * Make “keep invaid values” test async * Prevent interference of value entry in number input * Remove unused `floatClamp` function * Fix reset to `initialPosition` * Fix a couple tests for controlled `RangeControl` * Fix `RangeControl` reset * Ensure `InputControl`’s state syncing works after focus changes * Comment * Ignore NaN values in `useUnimpededRangedNumberEntry` * Refine use of event existence in state syncing effect hooks Co-authored-by: Marco Ciampini <marco.ciampo@gmail.com> Co-authored-by: Lena Morita <lena@jaguchi.com>
Configuration menu - View commit details
-
Copy full SHA for 769e69d - Browse repository at this point
Copy the full SHA 769e69dView commit details -
Configuration menu - View commit details
-
Copy full SHA for bbdbfc8 - Browse repository at this point
Copy the full SHA bbdbfc8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 80e7d58 - Browse repository at this point
Copy the full SHA 80e7d58View commit details -
Revert "Fix
RangeControl
reset from values out-of-range by multiple…… digits" This reverts commit bbdbfc8.
Configuration menu - View commit details
-
Copy full SHA for f1f4daa - Browse repository at this point
Copy the full SHA f1f4daaView commit details -
Revert "Finish making
InputControl
et al. more controllable (#40568)"This reverts commit 769e69d.
Configuration menu - View commit details
-
Copy full SHA for 0de33ab - Browse repository at this point
Copy the full SHA 0de33abView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8952d45 - Browse repository at this point
Copy the full SHA 8952d45View commit details -
Configuration menu - View commit details
-
Copy full SHA for 32eb218 - Browse repository at this point
Copy the full SHA 32eb218View commit details -
Configuration menu - View commit details
-
Copy full SHA for bb6b932 - Browse repository at this point
Copy the full SHA bb6b932View commit details -
Configuration menu - View commit details
-
Copy full SHA for d79aa03 - Browse repository at this point
Copy the full SHA d79aa03View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3ac6020 - Browse repository at this point
Copy the full SHA 3ac6020View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.