Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

InputControl: Fix undo when changing padding values #40518

Merged
merged 11 commits into from
May 30, 2022
Merged

InputControl: Fix undo when changing padding values #40518

merged 11 commits into from
May 30, 2022

Commits on May 29, 2022

  1. Fix undo when changing padding values

    @youknowriad @stokesman
    youknowriad authored and stokesman committed May 29, 2022
    Configuration menu
    Copy the full SHA
    070a66e View commit details
    Browse the repository at this point in the history

  2. Finish making InputControl et al. more controllable (#40568) 

    * Update `RangeControl` to play nice with revised `InputControl`

* Update `UnitControl` to play nice with revised `InputControl`

* Restore controlled mode to `RangeControl`

* Add missing ;

* Add comment after deleting `onChange`

* Update test of `RangeControl` to also test controlled mode

* Remove separate onChange call from reset handling in `RangeControl`

* Refine RESET logic of `InputControl` reducer

* Simplify refined RESET logic of `InputControl` reducer

* Restore initial position of `RangeControl` when without value

* Differentiate state sync effect hooks by event existence

* Add and use type `SecondaryReducer`

* Cleanup legacy `event.perist()`

* Simplify update from props in reducer

Co-authored-by: Lena Morita <lena@jaguchi.com>

* Ensure event is cleared after drag actions

* Avoid declaration of potential unused variable

* Add more reset unit tests for `RangeControl`

* Run `RangeControl` unit test in both controlled/uncontrolled modes

* Make “keep invaid values” test async

* Prevent interference of value entry in number input

* Remove unused `floatClamp` function

* Fix reset to `initialPosition`

* Fix a couple tests for controlled `RangeControl`

* Fix `RangeControl` reset

* Ensure `InputControl`’s state syncing works after focus changes

* Comment

* Ignore NaN values in `useUnimpededRangedNumberEntry`

* Refine use of event existence in state syncing effect hooks

Co-authored-by: Marco Ciampini <marco.ciampo@gmail.com>
Co-authored-by: Lena Morita <lena@jaguchi.com>
    @stokesman @ciampo @mirka
    3 people committed May 29, 2022
    Configuration menu
    Copy the full SHA
    769e69d View commit details
    Browse the repository at this point in the history

  3. Fix RangeControl reset from values out-of-range by multiple digits

    @stokesman
    stokesman committed May 29, 2022
    Configuration menu
    Copy the full SHA
    bbdbfc8 View commit details
    Browse the repository at this point in the history

  4. Add changelog entry

    @stokesman
    stokesman committed May 29, 2022
    Configuration menu
    Copy the full SHA
    80e7d58 View commit details
    Browse the repository at this point in the history

  5. Revert "Fix RangeControl reset from values out-of-range by multiple… 

    … digits"

This reverts commit bbdbfc8.
    @stokesman
    stokesman committed May 29, 2022
    Configuration menu
    Copy the full SHA
    f1f4daa View commit details
    Browse the repository at this point in the history

  6. Revert "Finish making InputControl et al. more controllable (#40568)" 

    This reverts commit 769e69d.
    @stokesman
    stokesman committed May 29, 2022
    Configuration menu
    Copy the full SHA
    0de33ab View commit details
    Browse the repository at this point in the history

  7. Have InputControl favor entered value for a render cycle

    @stokesman
    stokesman committed May 29, 2022
    Configuration menu
    Copy the full SHA
    8952d45 View commit details
    Browse the repository at this point in the history

  8. Run propagation effect when isDirty changes

    @stokesman
    stokesman committed May 29, 2022
    Configuration menu
    Copy the full SHA
    32eb218 View commit details
    Browse the repository at this point in the history

  9. Use event existence to eliminate extraneous onChange calls

    @stokesman
    stokesman committed May 29, 2022
    Configuration menu
    Copy the full SHA
    bb6b932 View commit details
    Browse the repository at this point in the history

  10. Keep change handler in a ref to pass react-hooks/exhaustive-deps

    @stokesman
    stokesman committed May 29, 2022
    Configuration menu
    Copy the full SHA
    d79aa03 View commit details
    Browse the repository at this point in the history

  11. Cleanup legacy event.persist calls

    @stokesman
    stokesman committed May 29, 2022
    Configuration menu
    Copy the full SHA
    3ac6020 View commit details
    Browse the repository at this point in the history