useSelect: cancel render queue in a more straightforward way #40433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +1 B (0%) Total Size: 1.23 MB
ℹ️ View Unchanged
|
youknowriad
approved these changes
Apr 19, 2022
Mamaduka
approved these changes
Apr 19, 2022
There was a problem hiding this comment.
The new queue method makes sense to me, and I love all the nice improvements to the useSelect hook ❤️
Thanks, @jsnajdr.
P.S.
I think we can remove this warning comment now (original discussion for ref):
gutenberg/packages/data/src/components/use-select/index.js
Lines 241 to 243 in a4da15b
jsnajdr
force-pushed
the
update/use-select-cancelling-callbacks
branch
from
a733319 to
96a393d
Compare
jsnajdr
force-pushed
the
update/use-select-cancelling-callbacks
branch
from
96a393d to
c05daff
Compare
|
Hey @jsnajdr I've noticed that this actually started throwing React warnings. You can try by selecting a block and then unselecting it. It seems there's a still some callbacks that are run after a useSelect component is unmounted. |
|
Seeing them too:
Going to investigate. |
|
I think I'll have to re-introduce the
The child has already unsubscribed, but the data store is still looping through the old list of listeners.
|
If we can do that somehow in the future, it would be great, it would allow us to avoid the zombie bug as well (the weird error handling and try/catch we have) |
|
I confirmed locally that adding the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the
useSelecthook runs in async mode, it defers the store update callbacks using@wordpress/priority-queue. On certain occasions, it needs to cancel the already scheduled callbacks. Until now, the cancelling was done by setting aisMountedAndNotUnsubscribingbool flag tofalse, and then flushing the queue, i.e., executing the scheduled callbacks, while checking theisMountedAndNotUnsubscribingflag inside the callbacks, making them into noops.This patch introduces a new
cancelmethod to@wordpress/priority-queue, and calls it inuseSelectwhen the intent is "cancel". That's more straightforward and easier to understand.The
flush()andcancel()methods are analogous to how Lodash names methods to flush and cancel functions returned fromdebounceorthrottle:How to test:
Verify that the unit test suite for
useSelectstill passes. Since #40321 the test suite should be sufficiently thorough to verify that a change like this one is OK.