Block Library: Mark new blocks to be included in WordPress core #40186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gziolo
requested review from
TimothyBJacobs,
spacedmonkey and
ajitbohra
as code owners
gziolo
requested review from
adamziel,
priethor,
ntsekouras,
carolinan,
annezazu,
bph and
cbravobernal
Would you please walk me through the reasoning here? |
|
Size Change: +17 B (0%) Total Size: 1.22 MB
ℹ️ View Unchanged
|
gziolo
commented
Apr 8, 2022
| * @return void | ||
| */ | ||
| function gutenberg_rest_comment_set_children_as_embeddable() { | ||
| add_filter( |
There was a problem hiding this comment.
@c4rl0sbr4v0 and @DAreRodz - is that still necessary for the Comment Template block?
There was a problem hiding this comment.
We need that function in order to show Comment Replies on the editor. Attached a video of what happens if we remove it.
removing_rest_extension.mov
There was a problem hiding this comment.
Great, thank you for the confirmation 👍🏻
gziolo
added
[Package] Block library
We don’t want to have the block editor setting fed with every possible global site setting. Discussion settings are used only when the comment-related blocks are inserted in the editor so we could use REST API instead. The challenge is that those settings are available through REST API for the admin users only. That's why we had to go with the fallback through the block editor settings. Besides, those aren't strictly editor settings but site settings. |
36 tasks
|
Ah alright! And the JS files from the other PR already rely on the __experimental name so there is nothing to change |
adamziel
approved these changes
Apr 8, 2022
juanmaguitar
approved these changes
Apr 8, 2022
gziolo
removed
the
Backport to WP 6.7 Beta/RC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Part of #39889.
Blocks to be included in WordPress 6.0 release:
Why?
We want to ship them to WordPress users in the 6.0 major release!
How?
Block definitions were moved to
__experimentalGetCoreBlocksfunction from__experimentalRegisterExperimentalCoreBlocksfunction.