Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest Posts block: remove columns-x class for list view #4017

Closed
wants to merge 134 commits into from
Closed

Latest Posts block: remove columns-x class for list view #4017

Changes from 1 commit
Commits
Show all changes
134 commits
Select commit Hold shift + click to select a range
b5d73e5
Add editor heading for screenreaders
Dec 12, 2017
e682f1e
Make post title contextual and translatable
Dec 12, 2017
98e560a
Remove NVDA hack.
Dec 12, 2017
683ecaf
Try block advanced settings dynamic menu item.
afercia Dec 13, 2017
12998a3
Fix blocks when useOnce is true
Rahmon Dec 14, 2017
fa71b71
Add speak messages.
afercia Dec 14, 2017
a329322
Add full coverage for REQUEST_POST_UPDATE_SUCCESS effect.
BE-Webdesign Dec 5, 2017
e6796f9
Updating effects to make use of matchers instead of explicit matching.
BE-Webdesign Dec 14, 2017
2a3e4a0
Block API: Refactor supportHTML as supports property
aduth Dec 14, 2017
a7dc698
Show column class only for grid
Soean Dec 14, 2017
2ec735c
Remove columns class for lists also in server-side rendering
Soean Dec 14, 2017
d82808e
Changes buttonProps to html attributes
Soean Dec 15, 2017
8a511f5
Fix when block hasn't been used yet in the post
Rahmon Dec 15, 2017
861c054
Try fainter disabled state
Dec 15, 2017
fb96084
Tests: Refactor tests for REQUEST_POST_UPDATE_SUCCESS effects
gziolo Dec 15, 2017
7f346ea
Merge pull request #3820 from WordPress/add/test/editor/effects/reque…
gziolo Dec 15, 2017
0f35fc6
Extensibility: Defer applying filters for component until it is about…
gziolo Dec 15, 2017
71a218f
Merge pull request #4033 from WordPress/try/fainter-disabled-state
Dec 15, 2017
5d81a0a
Merge pull request #3988 from Rahmon/fix/3968
aduth Dec 15, 2017
6fba36d
Components: Add withState higher-order component
aduth Dec 14, 2017
925acf9
Blocks: Port HTML block to use withState
aduth Dec 14, 2017
7cb404d
Merge pull request #4016 from WordPress/add/with-state
aduth Dec 15, 2017
bbf06e2
Merge pull request #4014 from WordPress/update/supports-html
aduth Dec 15, 2017
7fdf923
Minor refactoring: change from "find" to "some" function (#4052)
Rahmon Dec 16, 2017
3fc4d58
Merge pull request #3982 from WordPress/try/block-settings-menu-item-…
afercia Dec 18, 2017
7c917c9
Meta Boxes: Show the "advanced" metaboxes location
youknowriad Dec 13, 2017
5c33f6f
Framework: Introduce the data module (#3832)
youknowriad Dec 18, 2017
f718d8e
Blocks: Move logic for generating class name to BlockEdit component
gziolo Dec 14, 2017
1342736
Blocks: Add test for generated class name with BlockEdit
gziolo Dec 14, 2017
6e6356a
Editor: Move generatedClassName logic out of BlockListBlock
gziolo Dec 15, 2017
f2bcebb
Blocks: Make sure Reusable Blocks get class name apllied properly
gziolo Dec 18, 2017
3650811
Editor: Wrap invalid block preview with key
gziolo Dec 18, 2017
227a93f
Merge pull request #4009 from WordPress/update/generated-class-name-e…
gziolo Dec 18, 2017
1b35aac
Merge pull request #4029 from WordPress/update/block-audio-button-attr
Soean Dec 18, 2017
d9e1777
Implemented isInlineForTag mechanism
jorgefilipecosta Dec 12, 2017
ba6eb23
Added tag groups for headings and lists to the inlineWhitelistTagGrou…
jorgefilipecosta Dec 18, 2017
f181a08
Added test cases to isInlineContent to take into account the new isIn…
jorgefilipecosta Dec 18, 2017
6a287a4
Extensibility: Respect the 'enter_title_here' hook
youknowriad Dec 18, 2017
1effc72
Update Jest to v22.0.1
ntwb Dec 19, 2017
fcf70aa
Update Jest snapshots
ntwb Dec 19, 2017
af0773f
Update babel-jest to v22.0.1
ntwb Dec 19, 2017
ec3d7d5
Update eslint-plugin-jest to v21.5.0
ntwb Dec 19, 2017
d8db53a
Merge pull request #4073 from WordPress/update/jest
gziolo Dec 19, 2017
c43b3fa
Added querystringify npm dependency.
jorgefilipecosta Dec 18, 2017
c4c8e3d
Replaced getLatestPosts usage (wp.api.collections.Posts wrapper) with…
jorgefilipecosta Dec 15, 2017
e133c87
Recreate `package-lock.json` using Node.js 8.9.3 & npm 5.6.0 (#4075)
ntwb Dec 19, 2017
0257138
Move selectors and actions files to the store folder
youknowriad Dec 19, 2017
630fbde
Moved Categories Block edit to an external file.
jorgefilipecosta Dec 18, 2017
c1f7b19
Replaced getCategories usage (wp.api.collections.Categories wrapper) …
jorgefilipecosta Dec 19, 2017
64ac510
Add dynamic block documentation (#4067)
atimmer Dec 19, 2017
8f30966
3 column inserter
karmatosed Dec 19, 2017
1df0d52
Try improving mobile controls
Dec 20, 2017
ed74c1e
Blocks: Add the missing alignments classNames to the Cover Image Bloc…
youknowriad Dec 18, 2017
fb72e7f
Improve paragraph block description.
Dec 20, 2017
0645702
Rename "Classic Text" to "Classic".
Dec 20, 2017
34a13d3
Data Module: Restrict the state access to the module registering the …
youknowriad Dec 18, 2017
6a8b8f4
Widens the inserter
karmatosed Dec 20, 2017
5981cca
Left aligns the title
karmatosed Dec 20, 2017
14a046a
Move title to center again
karmatosed Dec 20, 2017
b0c9e6a
Remove references to obsolete class.
Dec 20, 2017
6b51d23
Block Mobile Toolbar: Extract as a separate component
youknowriad Dec 20, 2017
7c1cfae
Merge branch 'try/improved-mobile-tools' of github.com:WordPress/gute…
youknowriad Dec 20, 2017
6378974
Factory: Fix block creation with falsey default
aduth Dec 19, 2017
76ddebf
Merge pull request #4103 from WordPress/update/improve-paragraph-desc…
jasmussen Dec 20, 2017
c89e226
Merge pull request #4101 from WordPress/try/improved-mobile-tools
jasmussen Dec 20, 2017
e8ff9ec
Little polish to the top menu and inserter.
Dec 19, 2017
353ee9c
Make mobile scroll "normally".
Dec 19, 2017
d8a58ac
Fix regression with "fixed to block" toolbar
Dec 19, 2017
76f1527
Prevent Safari from zooming in when opening inserter
Dec 19, 2017
9721009
Define setAttributes before using it.
ryo-utsunomiya Dec 20, 2017
e5bafaa
Removed duplicate of buildTermsTree in HierarchicalTermSelector. (#4111)
jorgefilipecosta Dec 20, 2017
a510f3c
Merge pull request #4104 from WordPress/update/rename-classic-text
Dec 20, 2017
5b85f85
Merge pull request #4095 from WordPress/try/three-column-inserter
Dec 20, 2017
db193b6
Fix the radio control checked attribute
stevehenty Dec 1, 2017
293d90e
Polish permalink toolbar on mobile
Dec 21, 2017
af913fa
Merge pull request #4081 from WordPress/try/mobile-polish
jasmussen Dec 21, 2017
9c6143b
Use Post Type capabilities instead of All capabilities.
imath Dec 21, 2017
d980bdb
Added drag&drop upload to cover image. (#4061)
jorgefilipecosta Dec 21, 2017
5aabd70
Accessibility: Fix the accessibility of the menu items in the ellipsi…
youknowriad Dec 21, 2017
2bc1329
Refactor Reusable Blocks controller to use WP_REST_Posts_Controller
noisysocks Dec 15, 2017
ae17538
Add aria-label to code and HTML block textarea elements. #2027
tfrommen Oct 4, 2017
3220ce8
Update aria-label, and remove (superfluous) placeholder. #2027
tfrommen Oct 6, 2017
8cc8cbb
Code Block: Restore the placeholder
youknowriad Dec 22, 2017
c97ebf8
Allow for multi line text in button block
jahvi Aug 22, 2017
b614f03
Remove unnecessary line.
Dec 22, 2017
5c92e3d
Components: Allow explicitely overriding the ColorPalette colors per …
youknowriad Dec 22, 2017
b9d8f85
Heading <-> Cover Image transforms
mcsf Dec 21, 2017
99f5f1d
Merge pull request #4129 from WordPress/add/heading-cover-image-trans…
mcsf Dec 22, 2017
0c4457c
Remove unused variable from the_gutenberg_project function
gziolo Dec 22, 2017
f023754
Merge pull request #3937 from WordPress/try/edit-heading-round-2
gziolo Dec 22, 2017
2ee8fe4
Gallery Block: Drag and drop multiple images create a gallery block
youknowriad Dec 22, 2017
e109ff7
DropZone: Tweak its styling
youknowriad Dec 22, 2017
6f25976
Chrome: Replace the publish dropdown by a sidebar panel
youknowriad Dec 21, 2017
98414fe
Chrome: Allow multiple sidebars
youknowriad Dec 21, 2017
95457a6
Chrome: Slide in animation for the publish sidebar
youknowriad Dec 21, 2017
34d088d
Chrome: fix hasOpenSidebar selector
youknowriad Dec 21, 2017
21e5b26
Chrome: Fix animation speed of the publish sidebar
youknowriad Dec 21, 2017
2f27d54
Add tests for Editable.adaptFormatter()
BE-Webdesign Dec 9, 2017
204c6b8
Merge pull request #3894 from WordPress/add/test/editable/adapt-forma…
BE-Webdesign Dec 23, 2017
b393dbe
Add tests for Editable.getSettings()
BE-Webdesign Dec 9, 2017
06317d7
Merge pull request #3892 from WordPress/add/test/blocks/editable-2
BE-Webdesign Dec 23, 2017
22e5bbf
Add tests for ColorPalette component.
BE-Webdesign Dec 9, 2017
a99733d
Fix typo in comment. (#4154)
getsource Dec 23, 2017
79a74be
Merge pull request #3887 from WordPress/add/test/blocks/color-palette
BE-Webdesign Dec 23, 2017
e624d34
Try: Add toggle editor mode shortcut (#3755)
vladanost Dec 25, 2017
6a9ea01
Chrome: Hide the Excerpt Panel if the CPT doesn't support it
youknowriad Dec 25, 2017
ecee09e
Handle copy for single block selection
ellatrix Dec 25, 2017
c3be1b6
Meta Boxes: When the metaboxes are saving ensure the overlay covers t…
youknowriad Dec 26, 2017
0aaffae
Add 'No saved blocks' message to Inserter
noisysocks Dec 27, 2017
ebf841f
Taxonomiees: Improve Tags/Categories response size by limiting the re…
youknowriad Dec 26, 2017
daebcc3
Add text to meetup links
laras126 Dec 26, 2017
c5a8db5
Organization and intitial population of articles page
laras126 Dec 26, 2017
34c81b4
Latest posts: Only request required category fields. (#4179)
jorgefilipecosta Dec 27, 2017
9646747
Chrome: Hide The Taxonomies Panel if no taxonomy is available for the…
youknowriad Dec 26, 2017
45e9094
Blocks: Show the insertion point when the inserter is opened
youknowriad Dec 25, 2017
825eef6
Implemented editor-left&editor-right mixins.
jorgefilipecosta Dec 22, 2017
b24170a
Made notices always visible; Added sticky behaviour in notices for wi…
jorgefilipecosta Dec 21, 2017
e63deab
Used editor-left mixin for .editor-header styles.
jorgefilipecosta Dec 22, 2017
e3e849f
Refactor `PostSchedule` to make calendar/clock available as component…
travislopes Dec 27, 2017
40adaff
Merge pull request #4182 from WordPress/add/no-saved-blocks-message
noisysocks Dec 27, 2017
1ff0f5f
Merge pull request #4137 from WordPress/add/reusable-block-deletion-t…
noisysocks Dec 27, 2017
553ab2c
Blocks: Avoir reusable blocks styling
youknowriad Dec 26, 2017
3a3c3d5
UrlInput: Decode Post Title special chars
youknowriad Dec 26, 2017
003d533
Block API: Adding a description property to the block API
youknowriad Dec 25, 2017
b407ccc
Check if mac when displaying editor mode toggle shortcut (#4194)
vladanost Dec 28, 2017
67b12ea
Fix category in implementation of random image block
Rahmon Dec 28, 2017
5838037
Chrome: Hide the Featured Image Panel if the CPT doesn't support it
youknowriad Dec 25, 2017
beaa749
Chrome: Hide the discussion panel if no support for comments or track…
youknowriad Dec 25, 2017
ddfef35
Chrome: Hide the PostAuthor selector if the CPT doesn't support it
youknowriad Dec 25, 2017
2558f6e
Chrome: User the PostTypeSupportCheck to check Post Formats support
youknowriad Dec 25, 2017
c22bc9d
Chrome: Hide revisions if the CPT doesn't support it
youknowriad Dec 25, 2017
edf17df
Mobile: Enhance the redux mobile enhancer to use the MediaQueries API
youknowriad Dec 26, 2017
0a7d55a
Update node-sass to v4.7.2 (#4200)
ntwb Dec 29, 2017
d9dc680
Rebase
Soean Dec 29, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion blocks/library/latest-posts/index.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ function gutenberg_render_block_core_latest_posts( $attributes ) {
$class .= ' is-grid';
}

if ( isset( $attributes['columns'] ) ) {
if ( isset( $attributes['columns'] ) && 'grid' === $attributes['layout'] ) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on the surrounding code, it looks like this should check to make sure the layout key exists before checking its value.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can remove all isset() from this file, because the attributes were moved to the server in #2529
cc: @aduth

Copy link
Member

@aduth aduth Dec 15, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might still want the 'grid' === $attributes['layout'] check though since based on the behavior in the editor, it seems that columns are only relevant for the grid layout. Edit: Ah, that's the whole point of the PR I see 😅

$class .= ' columns-' . $attributes['columns'];
}

Expand Down