Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block API: Refactor supportHTML as supports property #4014

Merged
merged 1 commit into from
Dec 15, 2017

Conversation

aduth
Copy link
Member

@aduth aduth commented Dec 14, 2017

This pull request seeks to refactor the supportHTML property to use the since-introduced supports object on the block API, for consistency with other supports.

Before:

supportHTML: false,

After:

supports: {
    html: false,
},

Testing instructions:

Ensure unit tests pass:

npm run test-unit

Verify that the block settings menu "Edit as HTML" option is shown only if the block supports it, which is all blocks except for: categories, code, html, latest posts, shortcode.

@aduth aduth added the [Feature] Block API API that allows to express the block paradigm. label Dec 14, 2017
@gziolo
Copy link
Member

gziolo commented Dec 15, 2017

Code looks good. I didn't test.

@aduth aduth merged commit bbf06e2 into master Dec 15, 2017
@aduth aduth deleted the update/supports-html branch December 15, 2017 15:31
@aduth aduth mentioned this pull request Dec 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Block API API that allows to express the block paradigm.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants