Scope Nav Menu sidebar to Plugin only #40083
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getdave
added
the
[Feature] Navigation in Site View
getdave
requested review from
draganescu,
adamziel,
scruffian,
talldan and
gziolo
|
Size Change: +23 B (0%) Total Size: 1.22 MB
ℹ️ View Unchanged
|
draganescu
approved these changes
Apr 6, 2022
|
Adding here for good measure @talldan 's mention that we should also check "if the original PR introduced any new selectors, actions or other public APIs and conditionally excluding those from core". |
|
@getdave this change triggers the following warning in Site Editor - WP 6.0 betas.
|
|
I'll fix that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR scopes the new Nav Menu sidebar to be a Plugin only feature in order to ensure it does not get included in WordPress 6.0.
Why?
Please see reasons in #40080.
How?
I'm using
process.env.IS_GUTENBERG_PLUGINto scope the Nav Sidebar code itself and the toggle button in the Nav block toolbar.I have tried to optimise for dead code elimination by rendering either the component itself or a
React.Fragment. By using the true component only by way of a conditional Webpack will eliminate the dead code within theif()when we're not building for the Gutenberg Plugin.There may be a better way to achieve this - cc'ing @talldan who I believe created the
IS_GUTENBERG_PLUGINfunctionality.Testing Instructions
package.jsonfile and update the following line to befalsegutenberg/package.json
Line 22 in 21421dc
npm run dev.package.jsonback totrueagain after you test this PR 😄Screenshots or screencast
The following screenshots show the elements that should be excluded by this PR:
