Global Styles: Fix black inconsistencies in sidebar #40055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mirka
added
[Type] Bug
mirka
commented
Apr 5, 2022
packages/edit-site/src/components/global-styles/icon-with-current-color.js
Show resolved
Hide resolved
|
Size Change: +86 B (0%) Total Size: 1.22 MB
ℹ️ View Unchanged
|
7 tasks
jasmussen
approved these changes
Apr 6, 2022
There was a problem hiding this comment.
Nice one! Important detail.
On a separate note, I really wish we could have some sort of variable system so we wouldn't have to remember that the border radius is 2px, and the default color is #1e1e1e, but that those were just defined in one place and leveraged from that source.
ciampo
reviewed
Apr 6, 2022
There was a problem hiding this comment.
Thank you @mirka for working on this!
I had a look at the Global Styles sidebar, and found a few places where the text color is still not #1e1e1e:
- The "screen title" (but not the "back" chevron icon) rendered by
<ScreenHeader />(caused by theHeadingcomponent and this setting in particular, which I'm not sure is still relevant?)
- The text in the
<FontFamilyControl />component (can be seen when navigating to the "Typography" -> "Text" screen)
- The text in the
<LineHeightControl />component (can be seen when navigating to the "Typography" -> "Text" screen) — I guess we should look into changing the text color inInputControlto affect all of its descendant components?
On a separate note, I really wish we could have some sort of variable system so we wouldn't have to remember that the border radius is
2px, and the default color is#1e1e1e, but that those were just defined in one place and leveraged from that source.
Hey @jasmussen , when you mention these default values, do you mean that they should be the default for the Gutenberg "app", or the default for @wordpress/components ?
Regarding the @wordpress/components package:
- we do have a shared configuration (overall config, colors, and more in that
utilsfolder), but I don't believe that we use#1e1e1eas the default text color - we'd also like to tidy up this internal package configuration (and reconcile it with the sass variables as we slowly migrate to CSS-in-JS styles), although we're currently focused on other projects.
- finally, we are also definitely interested in exposing some of these "variables" for consumers of the package to tweak, and we're looking at the work on the new navigation with interest as it may help us to define these requirements better
packages/edit-site/src/components/global-styles/icon-with-current-color.js
Show resolved
Hide resolved
# Conflicts: # packages/components/CHANGELOG.md # packages/edit-site/src/components/global-styles/navigation-button.js # packages/edit-site/src/components/global-styles/screen-root.js # packages/edit-site/src/components/global-styles/style.scss
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #38934
What?
Fixes inconsistencies in the main black color used in the Global Styles sidebar. The correct black is
#1e1e1e.Why?
For visual consistency.
How?
IconWithCurrentColorthat adds afill: currentColorstyle to the icon.color: inheritto theItemGroupItem, ensure that the button color isn't overridden by a UA color.colorof theSurfacecomponent from#000000to#1e1e1e. (This wrong color was being inherited throughout the first sidebar view.)Testing Instructions
Check the colors in the Global Styles sidebar.
Screenshots or screencast
👇 For these block icons, I don't want to mess with the colors here because I think block icons can technically be colored SVGs.