Card: adjust border radius size #40032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ciampo
added
[Type] Enhancement
|
Size Change: +8 B (0%) Total Size: 1.22 MB
ℹ️ View Unchanged
|
|
Nice, this is better, thanks for keeping at it!
I think we need to apply Without it, and at a small 2px radius, it's almost imperceptible that the inner card gets cropped due to funky antialiasing: But if I change the background and increase the radius just to verify, it becomes clear that the card itself still cuts into the border:
Whereas if I apply the overflow to the card itself, like so: Everything looks right: That's not to say it should have a 10px radius, just showing the difference here as an example. |
|
Thank you for your review, @jasmussen ! The problem related to the Card content's "cutting" into the border (specifically for the Global Styles sidebar's preview box) should have been solved in #39980. With the changes from this PR applied, I can't reproduce the issue that you're describing (I tried on both my local machine and on gutenberg.run). Here are a few screenshots of what I see:
|
jasmussen
approved these changes
Apr 5, 2022
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Adjust the size of the
Card's border radius, so that the rendered border gets a radius of2pxWhy?
Since
Cardrenders its border via thebox-shadowprop instead of theborderprop, in order to render the expected border radius, the actual value passed via CSS needs to be1pxsmaller than the target radius.See #39980 (comment) for more context
How?
Subtract
1pxfrom the value used as theborder-radius.Testing Instructions
Make sure the
Cardrenders as expected in Storybook and in the Editor (for example, when used in the Global Styles sidebar for the styles preview box). In particular, make sure that the effective border radius rendered on screen is2px, matching the rounded corners of the other components.Screenshots or screencast