Block Locking: Styling changes for modal #39998
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Type] Enhancement
|
Size Change: -85 B (0%) Total Size: 1.22 MB
ℹ️ View Unchanged
|
|
Great! Before:
After:
What I miss here is the lines. As the lines have a way of creating a stronger connection between text and icon. One can easier see what is locked and what is unlocked. (Instead of adding the invisible line in the mind one can see the line visually.) |
|
Nice work! I like the absence of borders, we use them sparingly in other places as well. Two things: if possible we should change this CSS at the component level, i.e. affect the same interface that exists in the Preferences modal, so we don't need to have CSS that overwrites:
If we did that, it would look like this:
I'll entirely defer to @critterverse on getting these details right, she has some context that I don't have. One idea to submit is that if the icons on the right are a concern, we could move them left of the label, like so: That would also give some connective tissue to other places that list blocks:
What do you think? |
We don’t have separate components to build similar UIs, so not sure if this is possible. But it would be nice to revisit them in the future. There might a be new experimental components we could use. |
|
Cool, I'm happy to give a thumbs up, but I'd love a check by Channing! |
jasmussen
approved these changes
Apr 4, 2022
|
Thank you, @paaljoachim and @jasmussen. Let's wait for @critterverse's approval :) |
critterverse
approved these changes
Apr 4, 2022
|
This looks so much cleaner, thanks @Mamaduka!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
PR addresses general block locking modal feedback from #39950 (comment).
Changes made in this PR:
minusicon is displayed.Testing Instructions
Screenshots or screencast