mapResolveSelectors: exclude all meta-selectors, handle selectors without resolvers #39976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsnajdr
added
[Type] Bug
|
Size Change: +52 B (0%) Total Size: 1.22 MB
ℹ️ View Unchanged
|
adamziel
approved these changes
Apr 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes two bugs in
wp.data.resolveSelect:resolveSelectoris supposed to not contain the store's meta-selectors (the ones that query resolution status). There should be only the "native" selectors. That used to work, but then a handful of new meta-selectors were added, andresolveSelectwasn't updated. This PR fixes that.The PR contains two new unit tests that illustrate both issues nicely. In the unit test suite, I also switched from Jest fake timers to real ones, saving us a few calls to
jest.runAllTimers.