Query page numbers block: add same supports that next/prev page have #39835
+20
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaggieCabrera
requested review from
ajitbohra,
mkaz,
ryanwelcher and
juanmaguitar
as code owners
MaggieCabrera
added
the
[Block] Query Pagination
MaggieCabrera
requested review from
scruffian,
kjellr,
ramonjd,
ntsekouras,
andrewserong and
carolinan
ntsekouras
approved these changes
Mar 29, 2022
Co-authored-by: Nik Tsekouras <ntsekouras@outlook.com>
scruffian
approved these changes
Mar 29, 2022
|
Thanks for following up here, Maggie! |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes #38386 as an alternative to #38508 In this case I'm only adding the color/typography supports as per this comment. We can revisit this block at a later date to add spacing options, but this is a safe first step to bring the block in line with the prev/next page blocks in terms of user customization.
Why?
Before this PR you could customize the prev/next page blocks typography (make the text bold for example), but not the page numbers. This made query pagination look inconsistent if you chose to use page numbers.
How?
This PR adds the same supports that the other blocks have and updates the docs to reflect the change.
Testing Instructions
On a query loop block, add query pagination with numbers, the options for the block should be the same for the page numbers and prev/next page blocks
Screenshots or screencast
The screenshots show all the available options for the blocks, not just the ones that show by default: