Tests: Apply style variations using labels #39725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Type] Automated Testing
|
We should probably fix the click area issue as well 😄 But we can keep label improvement from this PR. |
|
The screenshot is a bit weird, it looks like the "Aa" and the dots are not centered as they should be. Maybe a missing height: 100% somewhere |
|
@youknowriad, maybe on P.S. I've to log out, but I can look into the height issue tomorrow. |
|
I've got a PR here that fixes the underlying issue with the previews - #39737. I'm not sure if the tests need to be changed, it looks like they caught a bug here. |
|
Excellent work, @talldan. I think selecting variation by label change still can be helpful. I will update the PR. |
youknowriad
approved these changes
Mar 25, 2022
| `//*[@role="button"][@aria-label="${ title }"]` | ||
| ); | ||
| await variation.focus(); | ||
| await page.keyboard.press( 'Enter' ); |
There was a problem hiding this comment.
Why focus and press instead of click?
There was a problem hiding this comment.
Because of the height issue #39737.
- I will revert this to click now that it's resolved.
- Update PR description.
Mamaduka
force-pushed
the
fix/style-variation-tests
branch
from
14ab530 to
bb41ca5
Compare
Mamaduka
changed the title
Mamaduka
changed the title
|
Size Change: 0 B Total Size: 1.21 MB ℹ️ View Unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Updates style variation select helper to use variation labels.
Why?
It matches how a user will interact with the panel.
How?
applyVariationto use variation label, now that they're supported - Add labels to the global styles variations #39322.Testing Instructions
Screenshots or screencast
CleanShot.2022-03-24.at.19.38.57.mp4