Quote v2: add innerblocks support #39704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oandregal
requested review from
TimothyBJacobs,
spacedmonkey and
ajitbohra
as code owners
oandregal
force-pushed
the
add/quote-block-v2-markup
branch
from
1c79969 to
fc9fae9
Compare
oandregal
changed the title
oandregal
requested review from
ntsekouras,
jorgefilipecosta,
youknowriad,
gziolo and
ellatrix
|
Size Change: +313 B (0%) Total Size: 1.21 MB
ℹ️ View Unchanged
|
youknowriad
reviewed
Mar 24, 2022
youknowriad
reviewed
Mar 24, 2022
youknowriad
reviewed
Mar 24, 2022
| "keywords": [ "blockquote", "cite" ], | ||
| "textdomain": "default", | ||
| "attributes": { | ||
| "attribution": { |
There was a problem hiding this comment.
Why not just reuse the same attribute name as the existing quote "citation"?
There was a problem hiding this comment.
(reasoning being to make the least possible breaking changes)
There was a problem hiding this comment.
The original discussion #25892 (comment)
There was a problem hiding this comment.
The problem is that it's a breaking change for folks using quotes in "CPT templates". That said, I think the problem will still exist for folks using the "value" attribute which now becomes inner blocks. So would be good to provide a "migration" for these templates. We don't have "migrations" at the framework level but maybe we can start adhoc:
- Leave the old and new attributes
- if we detect a block with the old attributes, use a
useEffector something to migrate the attributes.
The ideal scenario would be to implement "migrations" in addition to "deprecations".
There was a problem hiding this comment.
Even if we maintain the name, the selector has changed from cite to figcaption, so it's going to be a breaking change for anyway.
There was a problem hiding this comment.
For the selector change, the deprecate handles it for us but we don't have a migration mechanism when the starting point is a block object, not markup.
There was a problem hiding this comment.
Oh, thanks for the clarification.
oandregal
force-pushed
the
add/quote-block-v2
branch
from
29dc699 to
c9e4e17
Compare
Co-authored-by: Ella van Durpe <4710635+ellatrix@users.noreply.github.com>
Co-authored-by: Dennis Snell <dennis.snell@automattic.com> Co-authored-by: Ari Stathopoulos <aristath@gmail.com>
oandregal
force-pushed
the
add/quote-block-v2-markup
branch
from
fc9fae9 to
7de5a5f
Compare
|
@youknowriad @ntsekouras your feeback was addressed. Do you think we can land this to continue iterating? There's two changes that can be worked in parallel when this lands (see issue description for more details): bring the transformations + iterate on the attribution behavior (focus, etc). |
youknowriad
approved these changes
Mar 24, 2022
|
Using a different |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #15486
Related #25892
Depends on #39703
What?
This PR makes the Quote v2 support inner blocks.
How?
The markup for this block behaves this way: without an attribution a quote is a simple
<blockquote />but with an attribution we follow the HTML spec with<figure><blockquote /><ficaption /></figure>.I've added as co-authors all the people that had contributed to the original PR.
Testing Instructions
quote-block-markup.mp4
Follow-ups
As per the conversations at #25892 we want the attribution to behave like this:
By defering this to a follow-up we can unblock changes to bring transformations in parallel.