Fix flaky test by finalising request resolution in Nav block e2e test #39633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getdave
added
[Type] Code Quality
getdave
changed the title
|
Size Change: 0 B Total Size: 1.21 MB ℹ️ View Unchanged
|
|
@talldan I wonder if your expert knowledge of e2e tests can shed any light on this. It passes locally but is flaky on CI. When the block is added with the The question is why does the request sometimes not match? |
getdave
force-pushed
the
try/fix-shows-loading-indicator-flaky-test
branch
from
cd58c9d to
8f3de45
Compare
|
@getdave I don't know for sure. I'd recommend having a look through the docs for request interception and then taking a look at how I wonder if there's an issue in that this code never calls Having said that, I don't know that the request technically needs to resolve. The promise code might not be necessary at all. The tests don't do anything after the promise resolves, so maybe the easiest option is to not resolve. |
I guess I didn't want to risk having a unfulfilled |
getdave
changed the title
|
@talldan I took a more careful look at |
|
Github Actions are down now so I'll have to wait until tomorrow to see if this works on CI. Oh the suspense! |
getdave
force-pushed
the
try/fix-shows-loading-indicator-flaky-test
branch
from
0d97f3b to
a624392
Compare
|
Ok this passed 5 times without issue. Going to merge and 🙏 that fixes it. |
scruffian
approved these changes
Mar 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes to the e2e tests to resolve #39231.
Closes #39231.
Why?
This e2e test keeps failing #39231 because the resolution function maybe be null and not callable.
How?
Conditionalises the calling of the resolution function to check whether it is a function.
Testing Instructions
Screenshots or screencast