Add __experimentalGetGlobalBlocksByName selector #39610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
|
Size Change: +31 B (0%) Total Size: 1.21 MB
ℹ️ View Unchanged
|
scruffian
reviewed
Mar 21, 2022
| return EMPTY_ARRAY; | ||
| } | ||
| const clientIds = getClientIdsWithDescendants( state ); | ||
| const foundBlocks = clientIds.filter( ( clientId ) => { |
There was a problem hiding this comment.
Could we just return the result of the filter? Do we need to use the EMPTY_ARRAY const?
There was a problem hiding this comment.
Filter will return a new array reference. Thus we use the reference to a constant object reference EMPTY_ARRAY so as to avoid returning a new object reference if the selector returns "nothing". It's a minor perf thing but it could make a big difference in certain components.
There was a problem hiding this comment.
I see Kerry even wrote a test to validate that. See the final it() in the tests.
|
What is it that makes |
|
@getdave Thanks for adding this. It has allowed me to optimize a little bit of the logic in #29739. @draganescu The term is already used by |
jostnes
pushed a commit
to jostnes/gutenberg
that referenced
this pull request
Mar 23, 2022
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR adds a new selector:
__experimentalGetGlobalBlocksByName.Why?
This is a sub PR spun out of #39290.
This selector returns all global blocks that match a given blockName. It also includes nested blocks.
This is required by #39290 to quickly get a list (including nested blocks) of any Navigation blocks currently within the current post/template.
How?
This selector is added to the
@wordpresss/block-editorpackage.Testing Instructions
Consoledrawer on any Editor page.wp.data.select('core/block-editor').__experimentalGetGlobalBlocksByName(%%YOUR BLOCK NAME HERE%%)replacing the placeholder with a block you know is in the current post/template (egcore/paragraph).Screenshots or screencast