Add aria-selected and multiselect to TreeGrid, plus Home and End key support to List View #39600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +46 B (0%) Total Size: 1.21 MB
ℹ️ View Unchanged
|
8 tasks
|
@tellthemachines Is this needed anymore? |
|
@alexstine nope, changes were added in #39272. Closing this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Adds
aria-selectto TreeGrid rows, and amultiselectablerole to the TreeGrid itself.Adds multiselect support with Home and End key to List View.
Why?
The Home and End key part is an alternative to #39272; I'm hoping that setting the aria roles on the TreeGrid will make screen readers announce a multi-selection without also reading out the currently focused item. This may not work, but I thought it was worth a try 🤷
How?
See above!
Testing Instructions
Test the following steps using a screen reader, or even better, test on multiple screen readers.
Screenshots or screencast