Core Data: Pass explicit undefined initial value to createContext
#39526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Part of #39211 Previously we have been calling `createContext()` without any arguments, but there's a funny note in the official React type for that function. > // If you thought this should be optional, see > // DefinitelyTyped/DefinitelyTyped#24509 (comment) Although not passing an argument is practically the same as passing `undefined` as the argument we have a type error that TypeScript doesn't like while we're relying on it to parse JS files with the JSDoc typings. In this patch we're just adding the explicit `undefined` which should have no behavioral change on the output but removes the type issue.
|
Size Change: +3 B (0%) Total Size: 1.16 MB
ℹ️ View Unchanged
|
adamziel
approved these changes
Mar 17, 2022
jostnes
pushed a commit
to jostnes/gutenberg
that referenced
this pull request
Mar 23, 2022
…WordPress#39526) Part of WordPress#39211 Previously we have been calling `createContext()` without any arguments, but there's a funny note in the official React type for that function. > // If you thought this should be optional, see > // DefinitelyTyped/DefinitelyTyped#24509 (comment) Although not passing an argument is practically the same as passing `undefined` as the argument we have a type error that TypeScript doesn't like while we're relying on it to parse JS files with the JSDoc typings. In this patch we're just adding the explicit `undefined` which should have no behavioral change on the output but removes the type issue.
dmsnell
added a commit
that referenced
this pull request
Mar 31, 2022
In this commit we're cleaning up type issues in the core-data package that prevent us from telling TypeScript to run on the package and all of its existing code, even the JS files. After these changes we should be able to do so and start converting more modules to TypeScript with less friction. This patch follows a series of other smaller updates: - #39212 - #39214 - #39225 - #39476 - #39477 - #39479 - #39480 - #39525 - #39526 - #39655 - #39656 - #39659 It was built in order to support ongoing work to add types to the `getEntityRecord` family of functions in #39025.
dmsnell
added a commit
that referenced
this pull request
Apr 1, 2022
In this commit we're cleaning up type issues in the core-data package that prevent us from telling TypeScript to run on the package and all of its existing code, even the JS files. After these changes we should be able to do so and start converting more modules to TypeScript with less friction. This patch follows a series of other smaller updates: - #39212 - #39214 - #39225 - #39476 - #39477 - #39479 - #39480 - #39525 - #39526 - #39655 - #39656 - #39659 It was built in order to support ongoing work to add types to the `getEntityRecord` family of functions in #39025.
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Part of #39211
Previously we have been calling
createContext()without anyarguments, but there's a funny note in the official React type
for that function.
Although not passing an argument is practically the same as passing
undefinedas the argument we have a type error that TypeScriptdoesn't like while we're relying on it to parse JS files with the
JSDoc typings.
In this patch we're just adding the explicit
undefinedwhich shouldhave no behavioral change on the output but removes the type issue.
Why?
We want to do great things with the core-data type system but all of these little nuisances get in the way when we're trying to study those things in isolation. This is a preparatory change to eliminate some of the noise in the existing types.
Testing Instructions
Please verify the approach of passing
undefinedand that it's safe.