Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress freeform block contenteditable warning #395

Merged
merged 1 commit into from
Apr 11, 2017

Conversation

aduth
Copy link
Member

@aduth aduth commented Apr 10, 2017

Related: #335

This pull request seeks to silence a warning logged to the console by the freeform fallback block. While not great as a permanent solution, this at least temporarily helps clear the console in case true errors are to occur. A more permanent solution will be to implement the freeform block in such a way that it handles and appropriately displays arbitrary markup (perhaps tied to #365).

Testing instructions:

Verify that warnings relating to contenteditable are no longer logged to the developer tools console.

@aduth aduth added the Framework Issues related to broader framework topics, especially as it relates to javascript label Apr 10, 2017
@mtias mtias merged commit d0e3389 into master Apr 11, 2017
@mtias mtias deleted the fix/suppress-contenteditable-warning branch April 11, 2017 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Framework Issues related to broader framework topics, especially as it relates to javascript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants