Storybook: Ensure rerender for RTL switcher #38963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mirka
added
Internationalization (i18n)
|
Size Change: 0 B Total Size: 1.15 MB ℹ️ View Unchanged
|
ciampo
approved these changes
Feb 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes a re-rendering issue in the Storybook RTL switcher that @ciampo noticed in #37769 (review).
Background
The Storybook RTL switcher requires a forced rerender after switching. This is because RTL styles in Emotion have to actively call
i18n.isRTL()to get the current RTL value, rather than getting it from props or context.The original RTL switcher used the
forceReRender()function exported from@storybook/react, which is basically undocumented. It worked in most cases but apparently not all. The standardkeyapproach seems to be more reliable.Testing Instructions
npm run storybook:devDividercomponent.marginStartto20.Some other RTL'ed Emotion component stories (e.g.
RangeControl) should not have regressed.I also tried to break it by memoizing
Divider, but it didn't break:Screenshots
CleanShot.2022-02-22.at.02.22.49.mp4
Types of changes
Storybook only.
Checklist:
*.native.jsfiles for terms that need renaming or removal).