Lowered specificity of alignment rules for support layout so wide alignments work. #38947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaggieCabrera
requested review from
TimothyBJacobs and
spacedmonkey
as code owners
MaggieCabrera
changed the title
|
Nice, and thanks for the incredibly fast PR! I'd like to test more, but this appears to be working on the frontend: I'm not seeing it working in the editor: Are there two instances of these rules that need to be updated? I'm seeing this code in the inspector for the editor:
When I update that to use the new |
You are right, I missed that, good catch! Should work now |
MaggieCabrera
force-pushed
the
fix-specificity-for-alignments
branch
from
f4b0e44 to
751d2d7
Compare
jasmussen
approved these changes
Feb 21, 2022
There was a problem hiding this comment.
The original div removal change is important, and in the name of responding quickly to these side-effects, I think we should land it. It works well for fullwide, wide, floated, and content widths in editor and frontend:
Note that the fullwide not being fullwide in the editor, as best I can tell, is a padding issue with TT2, one which requires a bit more of a holistic solution we didn't get to in time for 5.9.
Also, to the best of my reading of the :where selector, this is what it was designed for, and it helps lower the specificity instead of raise, which should only make this safer than it was before.
I would love more testing and sanity checks, CC: @jffng if you have time, since you reported the original issue. But I'd be happy to land this soon so we can see if there are additional issues.
|
Size Change: +6 B (0%) Total Size: 1.15 MB
ℹ️ View Unchanged
|
+1. Tested across a variety of block themes and this change restores the correct alignment and preserves the intention of the original PR, thank you both! |
8 tasks
cbravobernal
added
the
[Type] Bug
cbravobernal
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#38613 introduced a bug where wide alignments max-width rules where less specific than the new ones introduced for general alignments. This PR reduced the specificity of the new rule so wide alignments work again.
Props to @jasmussen for the code
Testing Instructions
Test on a block theme that wide alignments have the correct max-width
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist:
*.native.jsfiles for terms that need renaming or removal).