-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable tooltip for the main dashboard button #38790
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Package] Edit Post
/packages/edit-post
[Type] Enhancement
A suggestion for improvement.
General Interface
Parts of the UI which don't fall neatly under other labels.
labels
Feb 14, 2022
Size Change: +7 B (0%) Total Size: 1.15 MB
ℹ️ View Unchanged
|
tellthemachines
approved these changes
Feb 15, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice improvement! Tooltip is displayed on both hover and focus ✅
Thanks for the review, @tellthemachines. |
8 tasks
30 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
General Interface
Parts of the UI which don't fall neatly under other labels.
[Package] Edit Post
/packages/edit-post
[Type] Enhancement
A suggestion for improvement.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
FullscreenModeClose
button has correct labels set, based on post type'sview_items
value. PR enables tooltip that's displayed on hover.Resolves #38789.
Testing Instructions
Screenshots
Types of changes
Enhancement
Checklist:
*.native.js
files for terms that need renaming or removal).