Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Gallery block code ownership #38722

Merged
merged 2 commits into from
Feb 14, 2022
Merged

Conversation

mkevins
Copy link
Contributor

@mkevins mkevins commented Feb 11, 2022

Description

This PR updates the CODEOWNERS to remove @mkevins from the Gallery block. This was originally added as an aid to help monitor changes this block since this is a fairly non-trivial block in terms of complexity, which shares edit.js across web, iOS, and Android platforms. As a result of a recent shift in day-to-day team focus, I will no longer be monitoring these changes.

Testing coverage

With increasing coverage via automated integration testing coming soon, this ownership role may become less relevant going forward, however, if it is valuable to the continued maintenance on an interim basis, we can add a user here as well. cc: @hypest

Testing Instructions

N/A

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • I've tested my changes with keyboard and screen readers.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR (please manually search all *.native.js files for terms that need renaming or removal).
  • I've updated related schemas if appropriate.

@mkevins mkevins added the [Block] Gallery Affects the Gallery Block - used to display groups of images label Feb 11, 2022
@hypest
Copy link
Contributor

hypest commented Feb 11, 2022

Thanks for the ping @mkevins ! Yeah, let's have @geriux be marked as the codeowner for a bit. Gerardo, I guess feel free to push a commit to add your handle. Thanks!

@geriux geriux requested a review from hypest February 14, 2022 08:55
Copy link
Contributor

@hypest hypest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! And, thanks for picking up the baton there @geriux ❤️

@hypest hypest merged commit 037c087 into trunk Feb 14, 2022
@hypest hypest deleted the try/change-gallery-code-owners branch February 14, 2022 10:45
@github-actions github-actions bot added this to the Gutenberg 12.7 milestone Feb 14, 2022
kirtangajjar added a commit to kirtangajjar/gutenberg that referenced this pull request Feb 14, 2022
Handle case of multiline plaintext

Remove redundant escaping

Handle case of multiline plaintext

Remove redundant escaping

Remove data-align divs for themes that support layout (WordPress#38613)

Change Gallery block code ownership (WordPress#38722)

* Remove mkevins from Gallery block codeowners

* Add @geriux as codeowner for the gallery block

Co-authored-by: Gerardo <gerardo.pacheco@automattic.com>

Handle case of multiline plaintext

Remove redundant escaping
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Gallery Affects the Gallery Block - used to display groups of images
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants