Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing link in @wordpress/components's CHANGELOG #38611

Merged
merged 1 commit into from
Feb 8, 2022
Merged

Fix missing link in @wordpress/components's CHANGELOG #38611

merged 1 commit into from
Feb 8, 2022

Conversation

ciampo
Copy link
Contributor

@ciampo ciampo commented Feb 8, 2022

Description

Add link to the CHANGELOG entry added in #38358

Testing Instructions

Check manually (no runtime changes)

Types of changes

Docs

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • I've tested my changes with keyboard and screen readers.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR (please manually search all *.native.js files for terms that need renaming or removal).
  • I've updated related schemas if appropriate.

@ciampo ciampo added [Type] Developer Documentation Documentation for developers [Package] Components /packages/components [Feature] Component System WordPress component system labels Feb 8, 2022
@ciampo ciampo requested a review from mirka February 8, 2022 08:36
@ciampo ciampo requested a review from ajitbohra as a code owner February 8, 2022 08:36
@ciampo ciampo self-assigned this Feb 8, 2022
@ciampo ciampo changed the title Fix missing link in @wordpress/componentss CHANGELOG Fix missing link in @wordpress/components's CHANGELOG Feb 8, 2022
talldan
talldan approved these changes Feb 8, 2022
View reviewed changes
Copy link
Contributor

@talldan talldan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, sorry I missed that in my code review. Thanks for fixing it.

@ciampo ciampo mentioned this pull request Feb 8, 2022
Merged
8 tasks
@ciampo ciampo merged commit 4e4e458 into trunk Feb 8, 2022
@ciampo ciampo deleted the fix/components-changelog-link branch February 8, 2022 13:32
@github-actions github-actions bot added this to the Gutenberg 12.6 milestone Feb 8, 2022
@alexstine
Copy link
Contributor

@ciampo Sorry about that. I thought GitHub automatically linked those. I know for next time. 👍

@ciampo
Copy link
Contributor Author

ciampo commented Feb 8, 2022

@ciampo Sorry about that. I thought GitHub automatically linked those. I know for next time. 👍

Don't worry, it's fine! Thank you for your contributions to Gutenberg and your commitment to improving its accessibility

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@talldan talldan talldan approved these changes

@mirka mirka Awaiting requested review from mirka

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

Assignees

@ciampo ciampo

Labels
[Feature] Component System WordPress component system [Package] Components /packages/components [Type] Developer Documentation Documentation for developers
Projects
None yet
Milestone
Gutenberg 12.6
Development

Successfully merging this pull request may close these issues.
3 participants
@ciampo @alexstine @talldan