Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Home template description typo #37843

Merged
merged 1 commit into from
Jan 11, 2022
Merged

Fix Home template description typo #37843

merged 1 commit into from
Jan 11, 2022

Conversation

talldan
Copy link
Contributor

@talldan talldan commented Jan 11, 2022 •
edited
Loading

Description

Fixes #37841

How has this been tested?

It's only really possible to test this in WordPress 5.8 with gutenberg active. To test:

  1. Open the site editor
  2. Open the sidebar using the 'W' icon
  3. Click Templates
  4. Find the 'Home' template and read its description.

When running WordPress 5.9 the string from WordPress core is used:
https://github.com/WordPress/wordpress-develop/blob/trunk/src/wp-includes/block-template-utils.php#L122

I've made a matching ticket and PR for core, but it's unclear to me if this can be changed for 5.9 now that the hard string freeze is in place:

Screenshots

Types of changes

Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • I've tested my changes with keyboard and screen readers.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR (please manually search all *.native.js files for terms that need renaming or removal).
  • I've updated related schemas if appropriate.

@talldan talldan added Internationalization (i18n) Issues or PRs related to internationalization efforts [Feature] Templates API Related to API powering block template functionality in the Site Editor Backport to WP 6.7 Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta labels Jan 11, 2022
@talldan talldan self-assigned this Jan 11, 2022
@talldan talldan requested a review from jameskoster January 11, 2022 02:03
@talldan talldan mentioned this pull request Jan 11, 2022
Closed
@talldan talldan removed the Backport to WP 6.7 Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta label Jan 11, 2022
Mamaduka
Mamaduka approved these changes Jan 11, 2022
View reviewed changes
Copy link
Member

@Mamaduka Mamaduka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @talldan.

@Mamaduka Mamaduka merged commit 4b98db9 into trunk Jan 11, 2022
@Mamaduka Mamaduka deleted the fix/typo branch January 11, 2022 07:33
@github-actions github-actions bot added this to the Gutenberg 12.4 milestone Jan 11, 2022
@talldan talldan added the Backport to WP 6.7 Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta label Jan 12, 2022
@talldan
Copy link
Contributor Author

talldan commented Jan 12, 2022

Adding the backport label again as the core patch was committed (for 5.9). It doesn't need to be backported, but good to keep the 5.9 branch in sync.

@noisysocks
Copy link
Member

Thanks for letting me know!

@noisysocks noisysocks removed the Backport to WP 6.7 Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta label Jan 17, 2022
noisysocks pushed a commit that referenced this pull request Jan 17, 2022
@talldan @noisysocks
Fix Home template description typo (#37843)
907fa5b
@noisysocks noisysocks mentioned this pull request Jan 18, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mamaduka Mamaduka Mamaduka approved these changes

@spacedmonkey spacedmonkey Awaiting requested review from spacedmonkey spacedmonkey is a code owner

@TimothyBJacobs TimothyBJacobs Awaiting requested review from TimothyBJacobs

@jameskoster jameskoster Awaiting requested review from jameskoster

Assignees

@talldan talldan

Labels
[Feature] Templates API Related to API powering block template functionality in the Site Editor Internationalization (i18n) Issues or PRs related to internationalization efforts
Projects
None yet
Milestone
Gutenberg 12.4
Development

Successfully merging this pull request may close these issues.

Typo on a string in get_default_block_template_types() function
3 participants
@talldan @noisysocks @Mamaduka