[History]: Fix redo after update/publish with transient edits #37840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntsekouras
added
[Type] Bug
ntsekouras
requested review from
mcsf,
Mamaduka,
youknowriad,
Copons,
ellatrix,
annezazu and
Addison-Stavlo
ntsekouras
commented
Jan 10, 2022
| @@ -164,15 +168,14 @@ describe( 'Template Revert', () => { | |||
| expect( contentBefore ).toBe( contentAfter ); | |||
| } ); | |||
|
|
|||
| it.skip( 'should show the original content after revert, clicking undo then redo in the header toolbar', async () => { | |||
| it( 'should show the original content after revert, clicking undo then redo in the header toolbar', async () => { | |||
There was a problem hiding this comment.
Other changes in this file are not relevant to the PR, but refactored a bit (correct function signatures, etc..).
|
Size Change: -11 B (0%) Total Size: 1.13 MB
ℹ️ View Unchanged
|
youknowriad
approved these changes
Jan 12, 2022
That's so true 😄 . I have other issues about history in my queue and I hope I'll be in a good place soon to try to simplify things there if there is room for it. |
|
Sorry, I'm a little bit late. I tested PR, and it works as expected.
I also want to echo the same sentiment 😄 |
|
It feels like we should back port this one, no? --cc @noisysocks |
youknowriad
added
the
Backport to WP Minor Release
|
I added this to the next "minor" as it doesn't seem that critical and I have set another redo bug similarly. |
Mamaduka
removed
the
Backport to WP Minor Release
Mamaduka
pushed a commit
that referenced
this pull request
Feb 16, 2022
* [History]: Fix redo after update/publish with transient edits * test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #37195
Maybe related: #37760
Investigation started with @youknowriad 's: #37446 (comment).
When we
savewe do not create an undo step in history and was implemented In this PR. With that in place when we have transient edits and update/publish, if weundowe cannotredothen, as in that case we use the last action(save) which is deliberately handled to return early withfakenoedits.This PR handles this case to follow the normal flow we have for transient edits.
We create transient edits when we update the same block attribute as in the previous action and also when we use
__unstableMarkNextChangeAsNotPersistentin a block for some initialization purposes in the first render. The latter case was the reason for the failing test withempty theme. Inempty theme's index.html file we hadn't setperPageand there is logic there to set this value. So when wereverted the template, the Query Loop's rendering created transient edits. So after saving we had the above problem.Testing instructions
Paragraphandupdate/publish.redoundois available and working as expectedBefore
before.mov
After
after.mov
I'd appreciate good testing here for any regression 😄