Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make component unit test for editor/components/warning/index.js #3780

Merged
merged 1 commit into from
Dec 4, 2017
Merged

Make component unit test for editor/components/warning/index.js #3780

merged 1 commit into from
Dec 4, 2017

Conversation

hideokamoto
Copy link
Contributor

@hideokamoto hideokamoto commented Dec 3, 2017

Description

Related to progress on the issue -> Unit Testing Components #641

Added some unit test scripts for Warning component.

How Has This Been Tested?

Run unit test command.

$ npm test

 PASS  editor/components/warning/test/index.js
  Warning
    ✓ should match snapshot (16ms)
    ✓ should has valid class (2ms)
    ✓ should show child error message element (6ms)

----------------------------------------------------|----------|----------|----------|----------|----------------|
File                                                |  % Stmts | % Branch |  % Funcs |  % Lines |Uncovered Lines |
----------------------------------------------------|----------|----------|----------|----------|----------------|
editor/components/warning                          |      100 |      100 |      100 |      100 |                |
 index.js                                          |      100 |      100 |      100 |      100 |                |

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows has proper inline documentation.

@gziolo gziolo added the [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. label Dec 4, 2017
@gziolo
Copy link
Member

gziolo commented Dec 4, 2017

This looks great, thanks for your contribution! 👍

@gziolo gziolo merged commit 69db55b into WordPress:master Dec 4, 2017
@hideokamoto hideokamoto deleted the add/test/warning branch December 4, 2017 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants