Restore canvas padding for classic themes #37741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
the
[Type] Regression
youknowriad
requested review from
Mamaduka,
kjellr,
jasmussen and
MaggieCabrera
youknowriad
force-pushed
the
restore/padding-non-fse-themes
branch
from
6d07f99 to
5f3f8ba
Compare
|
Size Change: +107 B (0%) Total Size: 1.13 MB
ℹ️ View Unchanged
|
Mamaduka
approved these changes
Jan 6, 2022
kjellr
approved these changes
Jan 6, 2022
youknowriad
added
the
Backport to WP 6.7 Beta/RC
|
I temptatively added the backport label. cc @noisysocks |
|
Yep this is OK to include 👍 |
jorgefilipecosta
pushed a commit
that referenced
this pull request
Jan 10, 2022
noisysocks
removed
the
Backport to WP 6.7 Beta/RC
noisysocks
pushed a commit
that referenced
this pull request
Jan 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #35884
This PR restores the 8px padding for classic themes like suggested by the discussion in the issue.
It adds the style to classic.scss meaning it's going to only apply to themes without theme.json (themes with theme.json can add their own padding in the file directly).
cc @noisysocks on whether we can still include this in 5.9 or not (like suggested in the issue)