Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make component unit test for component/panel/row.js #3774

Merged
merged 1 commit into from
Dec 3, 2017
Merged

make component unit test for component/panel/row.js #3774

merged 1 commit into from
Dec 3, 2017

Conversation

hideokamoto
Copy link
Contributor

@hideokamoto hideokamoto commented Dec 3, 2017

Description

Related to progress on the issue -> Unit Testing Components #641

Added some unit test scripts for PanelRow component.

How Has This Been Tested?

Run unit test command.

$ npm run test-unit
 PASS  components/panel/test/row.js
  PanelRow
    ✓ should defined default class name (18ms)
    ✓ should defined custom class name (4ms)
    ✓ should return child components (8ms)

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows has proper inline documentation.

Copy link
Contributor

@youknowriad youknowriad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the unit test. Looks good to me

@youknowriad youknowriad merged commit 7f518a4 into WordPress:master Dec 3, 2017
@hideokamoto hideokamoto deleted the add/test/panel/row branch December 3, 2017 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants