Initial drop event, and transform for images in HTML mode #3748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ephox-mogran
commented
Dec 1, 2017
| isMatch( html ) { | ||
| const wrapper = document.createElement( 'div' ); | ||
| wrapper.innerHTML = html; | ||
| return wrapper.childNodes.length === 1 && wrapper.childNodes[ 0 ].nodeName.toLowerCase() === 'img'; |
There was a problem hiding this comment.
This seems fragile. How exact would the HTML match need to be to create an image?
ephox-mogran
commented
Dec 1, 2017
| return ( | ||
| <DropZone | ||
| onFilesDrop={ dropFiles } | ||
| onDrop={ drop } |
There was a problem hiding this comment.
I think if these are going to be separate, then there needs to be some better logic to communicate which one should fire. Here I'm essentially checking if numFiles is zero, but that requires some idea of the implementation of onFilesDrop. I think there would be a better way.
|
Superseded by #4577. Thanks for the work on this @ephox-mogran! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Exploring #3744
There are two parts of this PR.
htmlthat transform HTML passed viadataTransferhtmlsource transform for image blocks.It's currently hooking into
onDropinBlockDropZone. It only does something if it detects there are no files being transferred, but that's not exactly an elegant way of deciding which drop handler to execute. They probably need to be orchestrated properly.How Has This Been Tested?
Screenshots (jpeg or gifs if applicable):
Types of changes
Checklist: