Add alt toolbar for image crop mode #37337
Draft
+81
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajlende
added
[Feature] Media
ajlende
force-pushed
the
update/image-crop-toolbar
branch
from
b04901a
to
8c30ffd
Compare
|
Size Change: +273 B (0%) Total Size: 1.12 MB
ℹ️ View Unchanged
|
Mamaduka
reviewed
Dec 15, 2021
| @@ -8,13 +8,15 @@ const BlockControlsBlock = createSlotFill( 'BlockControlsBlock' ); | |||
| const BlockControlsInline = createSlotFill( 'BlockFormatControls' ); | |||
| const BlockControlsOther = createSlotFill( 'BlockControlsOther' ); | |||
| const BlockControlsParent = createSlotFill( 'BlockControlsParent' ); | |||
| const BlockControlsAlt = createSlotFill( 'BlockControlsParent' ); | |||
There was a problem hiding this comment.
Suggested change
| const BlockControlsAlt = createSlotFill( 'BlockControlsParent' ); | |
| const BlockControlsAlt = createSlotFill( 'BlockControlsAlt' ); |
I am looking forward to this improvement. Feel free to ping me when PR is ready for testing.
|
I'm wondering if it would be worthwhile to set up a system allowing blocks to create their own editing layers/modes? There are a couple cases that may benefit from such a system:
Additionally, some blocks may need separate rendering depending on some external state and a layer could be used to edit each of those states.
The first set has only one rendering path with multiple editing layers. The second set has one rendering path per editing layer. I think we can focus on the first set for multiple editing layers and one rendering path for now, and later add a way to handle separate rendering paths based on external state. In addition to the designs from #23721 that this is currently based off of, #20193 (comment) has some more designs for what these 'layers' could look like for the toolbar. |
|
Discussion about my above comment can happen in #38108 |
|
Thanks for working on this. I think it'd be good to fix the accessibility issues with the crop tools with any improvement here - #24676. Especially if this is going to be a system that any block can use. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
First part in fixing #23721
Replace the entire toolbar when opening the image editor.
The toolbar is replaced by adding a new
altmode for the block in addition tovisualandhtmland a newaltslot for the toolbar.How has this been tested?
In the image block,
Screenshots
Types of changes
New feature
Checklist:
*.native.jsfiles for terms that need renaming or removal).