Global Styles: add blockDefault icon to navigation button #37313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h the navigation buttons in the sidebar, e.g., colors, layout etc Use the default blocks icon for the navigation button as used by the block card component.
ramonjd
added
[Type] Enhancement
|
Size Change: +103 B (0%) Total Size: 1.11 MB
ℹ️ View Unchanged
|
|
Closed by #37293 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves:
Description
From #36569
👋 What about adding an icon to the blocks navigation button to make it consistent with the navigation buttons in the sidebar, e.g., colors, layout etc?
The default blocks icon seems like a decent choice as it as used as the default "block" icon in the BlockIcon component.
How has this been tested?
Using a blocks-based theme, e.g., TwentyTwentyTwo, open the Site Editor Styles sidebar.
Check that the
blockDefaulticon appears next to the Blocks navigation button.Types of changes
Adding an icon prop to
NavigationButton, which already accepts it.Checklist:
*.native.jsfiles for terms that need renaming or removal).