Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility improvements for Columns and Column blocks. #37304

Closed
wants to merge 2 commits into from
Closed

Accessibility improvements for Columns and Column blocks. #37304

wants to merge 2 commits into from

Conversation

alexstine
Copy link
Contributor

@alexstine alexstine commented Dec 11, 2021

Description

Possible fix for: #30620

Accessibility improvements for Columns and Column blocks.

  • Render Columns as grid and Column as gridcell.
  • Add note on how to navigate the Columns/Column blocks via aria-describedby.

How has this been tested?

Tested with NVDA screen reader on Windows 10 in Firefox.

Screenshots

Types of changes

Bug fix

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • I've tested my changes with keyboard and screen readers.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR (please manually search all *.native.js files for terms that need renaming or removal).

@alexstine alexstine requested a review from ajitbohra as a code owner December 11, 2021 05:00
@alexstine alexstine requested a review from diegohaz December 11, 2021 05:02
@alexstine alexstine self-assigned this Dec 11, 2021
@alexstine alexstine added [a11y] Epic [Block] Columns Affects the Columns Block [Feature] Blocks Overall functionality of blocks [Package] Blocks /packages/blocks [Type] Enhancement A suggestion for improvement. [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). Needs Accessibility Feedback Need input from accessibility labels Dec 11, 2021
orientation: 'horizontal',
renderAppender: false,
} );
const ariaDescribedById = sprintf( '%s-description', clientId );
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we really need sprintf here? 🤔 I believe we can accomplish the same result concatenating with backticks.

Suggested change
const ariaDescribedById = sprintf( '%s-description', clientId );
const ariaDescribedById = `${ clientId }-description`;

Comment on lines +129 to +130
Use the Left and Right Arrow keys to navigate through the list
of columns.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will probably need to be translatable

Suggested change
Use the Left and Right Arrow keys to navigate through the list
of columns.
{ __( 'Use the Left and Right Arrow keys to navigate through the list of columns.' ) }

@alexstine
Copy link
Contributor Author

@aristath Thanks for the review. Conversation is continuing in the issue if this PR will be moving forward or not.

@alexstine
Copy link
Contributor Author

I may come back to this, but likely not. Looking at making a much bigger change that will hopefully fix this problem for all blocks instead of just Columns. There are others such as Navigation and blocks without contentEditable that really need some fixes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Columns Affects the Columns Block [Feature] Blocks Overall functionality of blocks [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). Needs Accessibility Feedback Need input from accessibility [Package] Blocks /packages/blocks [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants