-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Accessibility improvements for Columns and Column blocks. #37304
Conversation
orientation: 'horizontal', | ||
renderAppender: false, | ||
} ); | ||
const ariaDescribedById = sprintf( '%s-description', clientId ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we really need sprintf
here? 🤔 I believe we can accomplish the same result concatenating with backticks.
const ariaDescribedById = sprintf( '%s-description', clientId ); | |
const ariaDescribedById = `${ clientId }-description`; |
Use the Left and Right Arrow keys to navigate through the list | ||
of columns. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will probably need to be translatable
Use the Left and Right Arrow keys to navigate through the list | |
of columns. | |
{ __( 'Use the Left and Right Arrow keys to navigate through the list of columns.' ) } |
@aristath Thanks for the review. Conversation is continuing in the issue if this PR will be moving forward or not. |
I may come back to this, but likely not. Looking at making a much bigger change that will hopefully fix this problem for all blocks instead of just Columns. There are others such as Navigation and blocks without contentEditable that really need some fixes. |
Description
Possible fix for: #30620
Accessibility improvements for Columns and Column blocks.
How has this been tested?
Tested with NVDA screen reader on Windows 10 in Firefox.
Screenshots
Types of changes
Bug fix
Checklist:
*.native.js
files for terms that need renaming or removal).