Adding description prop to Picker component #37207
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
|
@iamthomasbishop I'd love a quick design check to see about the UX of the description if you have time! |
|
Size Change: 0 B Total Size: 1.11 MB ℹ️ View Unchanged
|
mchowning
added
the
Mobile App - i.e. Android or iOS
mchowning
reviewed
Dec 8, 2021
There was a problem hiding this comment.
Code looks good and is working well. It would be nice to go ahead and use the description in this PR if possible. Would you mind taking a look at wordpress-mobile/gutenberg-mobile#3963 and seeing if that might be easy to go ahead and implement. This is more of a nice-to-have and not a blocker for merging this PR.
Fixes #3962
Instead of linking to wordpress-mobile/gutenberg-mobile#3962 in the gutenberg-mobile repo this is linking to a PR in this repo because we just have the number. Let's make sure and update that so the proper issue is closed when this gets merged.
|
@illusean Thanks for the ping. We may want to consider more holistically when/where we're using this component in the future, but we can set that aside for the time being. This is looking pretty good, I'm only seeing a couple of spacing things to tidy up. AndroidIn general, the description looks a little bit out of place on Android but I think we can make it work if we tidy up the spacing a little bit. I was looking at our (design) component library and found that the Section Footer component (which I believe is FooterMessageControl on the code side) works nicely in terms of spacing/sizing. This message is slightly different than Here's what the description row would look like assuming we were to use the same sizing/spacing as the Section Footer component: iOSFor the iOS implementation, I'm only seeing one issue with spacing on the ActionSheet header. Based on a quick inspection, the spacing along the bottom looks like it's about ~10-11px larger than expected. Here's what I'm seeing: Let me know if you have any questions or concerns! Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds description prop to Picker component.
Fixes #3962
How has this been tested?
<Picker>in settings (block-actions-menu.native.js) --<Picker description={'test description'}Screenshots
Android
iOS
Types of changes
New feature. However, there will be no UI changes for user until the prop is used.
Checklist:
*.native.jsfiles for terms that need renaming or removal).